Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2708553002: MD system tray: Add user metrics for clicks on the Bluetooth toggle switch. (Closed)

Created:
3 years, 10 months ago by fukino
Modified:
3 years, 10 months ago
Reviewers:
tdanderson
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

MD system tray: Add user metrics for clicks on the Bluetooth toggle switch. In non-MD system tray, clicks on the Bluetooth toggle switch have been recorded. However, in MD system tray, those clicks are not recorded. This CL add the same metrics events in MD system tray as well. BUG=691152 TEST=Open chrome://user-actions and check if StatusArea_Bluetooth_Enabled and StatusArea_Bluetooth_Disabled are recorded when the toggle button is clicked in MD Bluetooth menu. TBR=tdanderson@chromium.org Review-Url: https://codereview.chromium.org/2691053003 Cr-Commit-Position: refs/heads/master@{#451236} (cherry picked from commit e95bae2c160909c52b01b269f90c63f46ab9039a) Review-Url: https://codereview.chromium.org/2708553002 . Cr-Commit-Position: refs/branch-heads/2987@{#592} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/65c62d676d968ece273b7954ea5137eaca0233a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708553002/1
3 years, 10 months ago (2017-02-20 04:07:29 UTC) #2
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-20 04:07:30 UTC) #4
fukino
3 years, 10 months ago (2017-02-20 04:11:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
65c62d676d968ece273b7954ea5137eaca0233a9.

Powered by Google App Engine
This is Rietveld 408576698