Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Issue 2691053003: MD system tray: Add user metrics for clicks on the Bluetooth toggle switch. (Closed)

Created:
3 years, 10 months ago by fukino
Modified:
3 years, 10 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD system tray: Add user metrics for clicks on the Bluetooth toggle switch. In non-MD system tray, clicks on the Bluetooth toggle switch have been recorded. However, in MD system tray, those clicks are not recorded. This CL add the same metrics events in MD system tray as well. BUG=691152 TEST=Open chrome://user-actions and check if StatusArea_Bluetooth_Enabled and StatusArea_Bluetooth_Disabled are recorded when the toggle button is clicked in MD Bluetooth menu. Review-Url: https://codereview.chromium.org/2691053003 Cr-Commit-Position: refs/heads/master@{#451236} Committed: https://chromium.googlesource.com/chromium/src/+/e95bae2c160909c52b01b269f90c63f46ab9039a

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
fukino
Terry, could you take a look?
3 years, 10 months ago (2017-02-14 01:55:43 UTC) #2
tdanderson
LGTM
3 years, 10 months ago (2017-02-14 23:03:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691053003/1
3 years, 10 months ago (2017-02-17 04:58:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/157190) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-17 05:01:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691053003/20001
3 years, 10 months ago (2017-02-17 05:16:01 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 06:08:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e95bae2c160909c52b01b269f90c...

Powered by Google App Engine
This is Rietveld 408576698