Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2708523003:
Make ParsedContentType more conformant to the spec (Closed)
DescriptionMake ParsedContentType more conformant to the spec
This CL fixes token and quoted-string handling. MHTML needs "relaxed" parsing,
so this CL adds a mode for the usage.
BUG=689731
Review-Url: https://codereview.chromium.org/2708523003
Cr-Commit-Position: refs/heads/master@{#452047}
Committed: https://chromium.googlesource.com/chromium/src/+/53a17807c9046399134294373031a0633e75e3d6
Patch Set 1 : fix #Patch Set 2 : fix #Patch Set 3 : fix #Patch Set 4 : fix #Patch Set 5 : fix #
Total comments: 8
Patch Set 6 : fix #
Depends on Patchset: Messages
Total messages: 45 (38 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Make ParsedContentType more conformant to the spec This CL fixes token and quoted-string handling. BUG=689731 ========== to ========== Make ParsedContentType more conformant to the spec This CL fixes token and quoted-string handling. MHTML needs "relaxed" parsing, so this CL adds a mode for the usage. BUG=689731 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yhirano@chromium.org changed reviewers: + kinuko@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
See https://src.chromium.org/viewvc/blink?revision=158314&view=revision for the "relaxed" parsing.
https://codereview.chromium.org/2708523003/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/platform/network/ParsedContentType.cpp (right): https://codereview.chromium.org/2708523003/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/platform/network/ParsedContentType.cpp:100: output = input.substring(start, index - start); nit: output could be StringView if we want to save allocation in some cases https://codereview.chromium.org/2708523003/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/platform/network/ParsedContentType.cpp:141: bool isEnd(const String& input, unsigned index) { Any reason this doesn't take unsigned& index? https://codereview.chromium.org/2708523003/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/platform/network/ParsedContentType.h (right): https://codereview.chromium.org/2708523003/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/platform/network/ParsedContentType.h:50: // manner, i.e., only ';' and '"' are treated as special characters. maybe add a link to the CL that changed default parsing mode Relax? https://codereview.chromium.org/2708523003/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/platform/network/ParsedContentType.h:55: ParsedContentType(const String&, Mode = Mode::Normal); nit: still need explicit
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2708523003/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/platform/network/ParsedContentType.cpp (right): https://codereview.chromium.org/2708523003/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/platform/network/ParsedContentType.cpp:100: output = input.substring(start, index - start); On 2017/02/21 11:43:02, kinuko wrote: > nit: output could be StringView if we want to save allocation in some cases Done. https://codereview.chromium.org/2708523003/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/platform/network/ParsedContentType.cpp:141: bool isEnd(const String& input, unsigned index) { On 2017/02/21 11:43:02, kinuko wrote: > Any reason this doesn't take unsigned& index? consume* eat the input and hence update the index. isEnd sounds like not modifying the input so I'm not using a reference here. https://codereview.chromium.org/2708523003/diff/140001/third_party/WebKit/Sou... File third_party/WebKit/Source/platform/network/ParsedContentType.h (right): https://codereview.chromium.org/2708523003/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/platform/network/ParsedContentType.h:50: // manner, i.e., only ';' and '"' are treated as special characters. On 2017/02/21 11:43:02, kinuko wrote: > maybe add a link to the CL that changed default parsing mode Relax? Done. https://codereview.chromium.org/2708523003/diff/140001/third_party/WebKit/Sou... third_party/WebKit/Source/platform/network/ParsedContentType.h:55: ParsedContentType(const String&, Mode = Mode::Normal); On 2017/02/21 11:43:02, kinuko wrote: > nit: still need explicit Done.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 160001, "attempt_start_ts": 1487775202391540,
"parent_rev": "fd5123b41f8f47b2b6b30ec4a2df36b7651a4ad0", "commit_rev":
"53a17807c9046399134294373031a0633e75e3d6"}
Message was sent while issue was closed.
Description was changed from ========== Make ParsedContentType more conformant to the spec This CL fixes token and quoted-string handling. MHTML needs "relaxed" parsing, so this CL adds a mode for the usage. BUG=689731 ========== to ========== Make ParsedContentType more conformant to the spec This CL fixes token and quoted-string handling. MHTML needs "relaxed" parsing, so this CL adds a mode for the usage. BUG=689731 Review-Url: https://codereview.chromium.org/2708523003 Cr-Commit-Position: refs/heads/master@{#452047} Committed: https://chromium.googlesource.com/chromium/src/+/53a17807c9046399134294373031... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:160001) as https://chromium.googlesource.com/chromium/src/+/53a17807c9046399134294373031... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
