Make ParsedContentType more conformant to the spec

third_party/WebKit/Source/platform/network/ParsedContentType.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 28 matching lines @@
 
 namespace blink {
 
 // ParsedContentType parses the constructor argument as specified in RFC2045
 // and stores the result.
 // FIXME: add support for comments.
 class PLATFORM_EXPORT ParsedContentType final {
   STACK_ALLOCATED();
 
  public:
-  // <index, length>
-  using SubstringRange = std::pair<unsigned, unsigned>;
-
-  explicit ParsedContentType(const String&);
+  // When |Relaxed| is specified, the parser parses parameter values in a sloppy
+  // manner, i.e., only ';' and '"' are treated as special characters.

[kinuko, 2017/02/21 11:43:02]

maybe add a link to the CL that changed default parsing mode Relax?

[yhirano, 2017/02/22 05:17:03]

Done.

+  enum class Mode {
+    Normal,
+    Relaxed,
+  };
+  ParsedContentType(const String&, Mode = Mode::Normal);

[kinuko, 2017/02/21 11:43:02]

nit: still need explicit

[yhirano, 2017/02/22 05:17:03]

Done.

 
   String mimeType() const { return m_mimeType; }
   String charset() const;
 
   // Note that in the case of multiple values for the same name, the last value
   // is returned.
   String parameterValueForName(const String&) const;
   size_t parameterCount() const;
 
   bool isValid() const { return m_isValid; }
 
  private:
   bool parse(const String&);
 
+  const Mode m_mode;
   bool m_isValid;
+
   typedef HashMap<String, String> KeyValuePairs;
   KeyValuePairs m_parameters;
   String m_mimeType;
 };
 
 }  // namespace blink
 
 #endif