MD OOBE: Focus network list when shown

MD OOBE: Focus network list when shown

This is a slightly simpler alternative to:
https://codereview.chromium.org/2705793002/

BUG=694733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2708253002
Cr-Commit-Position: refs/heads/master@{#452115}
Committed: https://chromium.googlesource.com/chromium/src/+/e96528b1b2250ef51580a706dd7950293944cfd3

[stevenjb, 2017-02-21 22:44:48]

Description was changed from

==========
MD OOBE: Focus network list when shown

This is a slightly simpler alternative to:
https://codereview.chromium.org/2705793002/

BUG=694733
==========

to

==========
MD OOBE: Focus network list when shown

This is a slightly simpler alternative to:
https://codereview.chromium.org/2705793002/

BUG=694733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-02-21 22:56:41]

stevenjb@chromium.org changed reviewers:
+ alemate@chromium.org

[stevenjb, 2017-02-21 22:56:41]

My solution ended up being pretty similar to yours, except that I prefer not to
do anything on attached() so that other UI is not impacted. Instead we should
explicitly focus the list when we show the dialog.

[Alexander Alekseev, 2017-02-21 23:07:10]

On 2017/02/21 22:56:41, stevenjb wrote:
> My solution ended up being pretty similar to yours, except that I prefer not
to
> do anything on attached() so that other UI is not impacted. Instead we should
> explicitly focus the list when we show the dialog.


Did you check that it works after EULA "Back" button is pressed?

[stevenjb, 2017-02-21 23:11:03]

On 2017/02/21 23:07:10, Alexander Alekseev wrote:
> On 2017/02/21 22:56:41, stevenjb wrote:
> > My solution ended up being pretty similar to yours, except that I prefer not
> to
> > do anything on attached() so that other UI is not impacted. Instead we
should
> > explicitly focus the list when we show the dialog.
> 
> 
> Did you check that it works after EULA "Back" button is pressed?

Ugh, you're right, it does not. We need a better hook for when that screen is
shown. Any suggestions?

[Alexander Alekseev, 2017-02-21 23:11:08]

On 2017/02/21 23:07:10, Alexander Alekseev wrote:
> On 2017/02/21 22:56:41, stevenjb wrote:
> > My solution ended up being pretty similar to yours, except that I prefer not
> to
> > do anything on attached() so that other UI is not impacted. Instead we
should
> > explicitly focus the list when we show the dialog.
> 
> 
> Did you check that it works after EULA "Back" button is pressed?

Oh, it will actually.

[Alexander Alekseev, 2017-02-21 23:14:48]

lgtm

[stevenjb, 2017-02-21 23:24:43]

On 2017/02/21 23:14:48, Alexander Alekseev wrote:
> lgtm

Unfortunately 'back' doesn't work, although it seems like it should.

The eula back button calls chrome.send('login.EulaScreen.userActed',
['back-button']).

I can't easily follow the chain of events that triggers, but it is never
triggering OobeDialogEleemnt.show(), so it is never firing show-dialog, so it is
never triggiring onNetworkSelectionScreenShown (which is also a problem in that
the network list will not be refreshed on back).

[Alexander Alekseev, 2017-02-21 23:33:52]

On 2017/02/21 23:24:43, stevenjb wrote:
> On 2017/02/21 23:14:48, Alexander Alekseev wrote:
> > lgtm
> 
> Unfortunately 'back' doesn't work, although it seems like it should.
> 
> The eula back button calls chrome.send('login.EulaScreen.userActed',
> ['back-button']).
> 
> I can't easily follow the chain of events that triggers, but it is never
> triggering OobeDialogEleemnt.show(), so it is never firing show-dialog, so it
is
> never triggiring onNetworkSelectionScreenShown (which is also a problem in
that
> the network list will not be refreshed on back).

Yes, I understood that you need another CL to make it work. And that your
solution will work with it.
So lgtm. Sorry for confusion.

[Alexander Alekseev, 2017-02-21 23:33:52]

On 2017/02/21 23:24:43, stevenjb wrote:
> On 2017/02/21 23:14:48, Alexander Alekseev wrote:
> > lgtm
> 
> Unfortunately 'back' doesn't work, although it seems like it should.
> 
> The eula back button calls chrome.send('login.EulaScreen.userActed',
> ['back-button']).
> 
> I can't easily follow the chain of events that triggers, but it is never
> triggering OobeDialogEleemnt.show(), so it is never firing show-dialog, so it
is
> never triggiring onNetworkSelectionScreenShown (which is also a problem in
that
> the network list will not be refreshed on back).

Yes, I understood that you need another CL to make it work. And that your
solution will work with it.
So lgtm. Sorry for confusion.

[stevenjb, 2017-02-21 23:34:22]

On 2017/02/21 23:33:52, Alexander Alekseev wrote:
> On 2017/02/21 23:24:43, stevenjb wrote:
> > On 2017/02/21 23:14:48, Alexander Alekseev wrote:
> > > lgtm
> > 
> > Unfortunately 'back' doesn't work, although it seems like it should.
> > 
> > The eula back button calls chrome.send('login.EulaScreen.userActed',
> > ['back-button']).
> > 
> > I can't easily follow the chain of events that triggers, but it is never
> > triggering OobeDialogEleemnt.show(), so it is never firing show-dialog, so
it
> is
> > never triggiring onNetworkSelectionScreenShown (which is also a problem in
> that
> > the network list will not be refreshed on back).
> 
> Yes, I understood that you need another CL to make it work. And that your
> solution will work with it.
> So lgtm. Sorry for confusion.

Ah, OK, thnaks!

[stevenjb, 2017-02-21 23:34:30]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:37:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:40:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 01:40:28]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[stevenjb, 2017-02-22 16:40:54]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-02-22 16:41:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 17:44:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487781654224820,
"parent_rev": "8c4ba287b0e85a33c6ec3a7a3d9007896f703cdb", "commit_rev":
"e96528b1b2250ef51580a706dd7950293944cfd3"}

[commit-bot: I haz the power, 2017-02-22 17:45:44]

Description was changed from

==========
MD OOBE: Focus network list when shown

This is a slightly simpler alternative to:
https://codereview.chromium.org/2705793002/

BUG=694733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD OOBE: Focus network list when shown

This is a slightly simpler alternative to:
https://codereview.chromium.org/2705793002/

BUG=694733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2708253002
Cr-Commit-Position: refs/heads/master@{#452115}
Committed:
https://chromium.googlesource.com/chromium/src/+/e96528b1b2250ef51580a706dd79...
==========

[commit-bot: I haz the power, 2017-02-22 17:45:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e96528b1b2250ef51580a706dd79...