Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2708253002: MD OOBE: Focus network list when shown (Closed)

Created:
3 years, 10 months ago by stevenjb
Modified:
3 years, 10 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-elements_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD OOBE: Focus network list when shown This is a slightly simpler alternative to: https://codereview.chromium.org/2705793002/ BUG=694733 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2708253002 Cr-Commit-Position: refs/heads/master@{#452115} Committed: https://chromium.googlesource.com/chromium/src/+/e96528b1b2250ef51580a706dd7950293944cfd3

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M chrome/browser/resources/chromeos/login/oobe_welcome.js View 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list.js View 1 1 chunk +23 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_select.html View 1 chunk +2 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_select.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
stevenjb
My solution ended up being pretty similar to yours, except that I prefer not to ...
3 years, 10 months ago (2017-02-21 22:56:41 UTC) #3
Alexander Alekseev
On 2017/02/21 22:56:41, stevenjb wrote: > My solution ended up being pretty similar to yours, ...
3 years, 10 months ago (2017-02-21 23:07:10 UTC) #4
stevenjb
On 2017/02/21 23:07:10, Alexander Alekseev wrote: > On 2017/02/21 22:56:41, stevenjb wrote: > > My ...
3 years, 10 months ago (2017-02-21 23:11:03 UTC) #5
Alexander Alekseev
On 2017/02/21 23:07:10, Alexander Alekseev wrote: > On 2017/02/21 22:56:41, stevenjb wrote: > > My ...
3 years, 10 months ago (2017-02-21 23:11:08 UTC) #6
Alexander Alekseev
lgtm
3 years, 10 months ago (2017-02-21 23:14:48 UTC) #7
stevenjb
On 2017/02/21 23:14:48, Alexander Alekseev wrote: > lgtm Unfortunately 'back' doesn't work, although it seems ...
3 years, 10 months ago (2017-02-21 23:24:43 UTC) #8
Alexander Alekseev
On 2017/02/21 23:24:43, stevenjb wrote: > On 2017/02/21 23:14:48, Alexander Alekseev wrote: > > lgtm ...
3 years, 10 months ago (2017-02-21 23:33:52 UTC) #9
Alexander Alekseev
On 2017/02/21 23:24:43, stevenjb wrote: > On 2017/02/21 23:14:48, Alexander Alekseev wrote: > > lgtm ...
3 years, 10 months ago (2017-02-21 23:33:52 UTC) #10
stevenjb
On 2017/02/21 23:33:52, Alexander Alekseev wrote: > On 2017/02/21 23:24:43, stevenjb wrote: > > On ...
3 years, 10 months ago (2017-02-21 23:34:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708253002/20001
3 years, 10 months ago (2017-02-21 23:37:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-22 01:40:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708253002/20001
3 years, 10 months ago (2017-02-22 16:41:30 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 17:45:45 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e96528b1b2250ef51580a706dd79...

Powered by Google App Engine
This is Rietveld 408576698