Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2705793002: cr-network-select: implement focus() (Closed)

Created:
3 years, 10 months ago by Alexander Alekseev
Modified:
3 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cr-network-select: implement focus() cr-network-select sometimes needs to be default-focused element. For example, this is needed in OOBE NEtwork selection dialog. This CL implements focus() that will focus the fist element in cr-network-list. BUG=676774 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M ui/webui/resources/cr_elements/network/cr_network_list.js View 1 chunk +34 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_select.html View 1 chunk +2 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_select.js View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (11 generated)
Alexander Alekseev
Please review.
3 years, 10 months ago (2017-02-18 05:03:21 UTC) #3
stevenjb
3 years, 10 months ago (2017-02-21 17:56:44 UTC) #12
This seems much more complicated than it should need to be. I will take a look.
Could you file a separate bug for this? The existing bug is only indirectly
related.

Powered by Google App Engine
This is Rietveld 408576698