Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2708213006: Expand FrameSeleciton::hasEditableStyle() to increase chances of hoisting update layout (Closed)

Created:
3 years, 10 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand FrameSeleciton::hasEditableStyle() to increase chances of hoisting update layout This patch expands |FrameSeleciton::hasEditableStyle()| to increase chance of hoisting update layout. Note: This is mechanical change to replace |selection().hasEditableStyle()| by |selection().computeVisibleSelectionInDOMTreeDeprecated().hasEditableStyle()| and manual change to |computeVisibleSelectionInDOMTree()| in explicit case, e.g. just after |computeVisibleSelectionInDOMTreeDeprecated()|. Following patch will remove deprecated version. This patch is apart of expanding expensive member functions in |FrameSelection|: - rootEditableElement() - hasEditableStyle() - isContentEditable() - isContentRichlyEditable() - getSelectionType() - base() - extent() - start() - end() - isNone() - isCaret() - isRange() BUG=694360 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2708213006 Cr-Commit-Position: refs/heads/master@{#452675} Committed: https://chromium.googlesource.com/chromium/src/+/0c3513655473a49b2ef7aeafb366f8ca74422a5b

Patch Set 1 : 2017-02-23T18:38:07 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
yosin_UTC9
PTAL Changes in core/editing
3 years, 10 months ago (2017-02-23 09:50:21 UTC) #6
Xiaocheng
lgtm
3 years, 10 months ago (2017-02-23 19:57:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708213006/1
3 years, 10 months ago (2017-02-23 23:35:06 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 23:41:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c3513655473a49b2ef7aeafb366...

Powered by Google App Engine
This is Rietveld 408576698