third_party/WebKit/Source/core/editing/FrameSelection.cpp - Issue 2708213006: Expand FrameSeleciton::hasEditableStyle() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2708213006: Expand FrameSeleciton::hasEditableStyle() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-23T18:38:07 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

index e64e78de969f5615c9e4ab38f5702af910c7b31b..7d88e250c1fb081613fe9ce2d39a081356331e03 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

@@ -474,8 +474,9 @@ void FrameSelection::invalidatePaintIfNeeded(

bool FrameSelection::shouldPaintCaret(const LayoutBlock& block) const {

DCHECK_GE(document().lifecycle().state(), DocumentLifecycle::LayoutClean);

bool result = m_frameCaret->shouldPaintCaret(block);

- DCHECK(!result || (computeVisibleSelectionInDOMTreeDeprecated().isCaret() &&

- hasEditableStyle()));

+ DCHECK(!result ||

+ (computeVisibleSelectionInDOMTreeDeprecated().isCaret() &&

+ computeVisibleSelectionInDOMTree().hasEditableStyle()));

return result;

}