Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2708093003: Disable NotificationsApiTest.TestBasicUsage for Win debug build (Closed)

Created:
3 years, 10 months ago by fdoray
Modified:
3 years, 10 months ago
Reviewers:
dewittj, Evan Stade
CC:
chromium-reviews, Peter Beverloo, chromium-apps-reviews_chromium.org, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable NotificationsApiTest.TestBasicUsage for Win debug build BUG=691913 TBR=dewittj@chromium.org Review-Url: https://codereview.chromium.org/2708093003 Cr-Commit-Position: refs/heads/master@{#452056} Committed: https://chromium.googlesource.com/chromium/src/+/59bef6e2cbf1b3058d14de15b4614a88fefc01ea

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/extensions/api/notifications/notifications_apitest.cc View 2 chunks +2 lines, -1 line 1 comment Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708093003/1
3 years, 10 months ago (2017-02-21 21:03:38 UTC) #2
Evan Stade
https://codereview.chromium.org/2708093003/diff/1/chrome/browser/extensions/api/notifications/notifications_apitest.cc File chrome/browser/extensions/api/notifications/notifications_apitest.cc (right): https://codereview.chromium.org/2708093003/diff/1/chrome/browser/extensions/api/notifications/notifications_apitest.cc#newcode193 chrome/browser/extensions/api/notifications/notifications_apitest.cc:193: #if (defined(OS_LINUX) || defined(OS_WIN)) && !defined(NDEBUG) instead of NDEBUG, ...
3 years, 10 months ago (2017-02-21 21:11:11 UTC) #4
Evan Stade
3 years, 10 months ago (2017-02-21 21:11:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-21 23:07:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708093003/1
3 years, 10 months ago (2017-02-22 15:03:13 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 15:22:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/59bef6e2cbf1b3058d14de15b461...

Powered by Google App Engine
This is Rietveld 408576698