Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6418)

Unified Diff: chrome/browser/extensions/api/notifications/notifications_apitest.cc

Issue 2708093003: Disable NotificationsApiTest.TestBasicUsage for Win debug build (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/notifications/notifications_apitest.cc
diff --git a/chrome/browser/extensions/api/notifications/notifications_apitest.cc b/chrome/browser/extensions/api/notifications/notifications_apitest.cc
index 3d372dfb4f1d18255e89c22523cf77d51936c852..1ebdf8afc360897a49ace3d4a32850180a9d2d8b 100644
--- a/chrome/browser/extensions/api/notifications/notifications_apitest.cc
+++ b/chrome/browser/extensions/api/notifications/notifications_apitest.cc
@@ -6,6 +6,7 @@
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/scoped_feature_list.h"
+#include "build/build_config.h"
#include "chrome/browser/apps/app_browsertest_util.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/extensions/api/notifications/notifications_api.h"
@@ -189,7 +190,7 @@ class NotificationsApiTest : public ExtensionApiTest {
} // namespace
// http://crbug.com/691913
-#if defined(OS_LINUX) && !defined(NDEBUG)
+#if (defined(OS_LINUX) || defined(OS_WIN)) && !defined(NDEBUG)
Evan Stade 2017/02/21 21:11:11 instead of NDEBUG, should we check DCHECK_IS_ON?
#define MAYBE_TestBasicUsage DISABLED_TestBasicUsage
#else
#define MAYBE_TestBasicUsage TestBasicUsage
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698