Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2707973007: Android: address lint warnings. (Closed)

Created:
3 years, 10 months ago by estevenson
Modified:
3 years, 10 months ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: address lint warnings. All suppressed lint warnings should have a comment explaining why they are necessary. This CL also removes suppressions that were fixed in https://codereview.chromium.org/2327833002/. BUG=635567 Review-Url: https://codereview.chromium.org/2707973007 Cr-Commit-Position: refs/heads/master@{#452273} Committed: https://chromium.googlesource.com/chromium/src/+/6d3d021829cb0df282840aab35f06b46598ad935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M build/android/lint/suppressions.xml View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
estevenson
ptal Andrew, we should probably look at all of these before we add the baseline ...
3 years, 10 months ago (2017-02-22 20:39:16 UTC) #2
agrieve
On 2017/02/22 20:39:16, estevenson wrote: > ptal Andrew, we should probably look at all of ...
3 years, 10 months ago (2017-02-22 21:34:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707973007/1
3 years, 10 months ago (2017-02-22 22:37:16 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 23:36:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6d3d021829cb0df282840aab35f0...

Powered by Google App Engine
This is Rietveld 408576698