Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: build/android/lint/suppressions.xml

Issue 2707973007: Android: address lint warnings. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/lint/suppressions.xml
diff --git a/build/android/lint/suppressions.xml b/build/android/lint/suppressions.xml
index 0066fe2453c5a28efba221283b55a8df9ca4f1ff..33882a2d2613da7eb92846a974044f08ec233c51 100644
--- a/build/android/lint/suppressions.xml
+++ b/build/android/lint/suppressions.xml
@@ -21,12 +21,14 @@ Still reading?
Note: PRODUCT_DIR will be substituted at run-time with actual
directory path (e.g. out/Debug)
-->
+ <!-- AllowBackup defaults to true, and causes a lint warning if not explicitly set. -->
<issue id="AllowBackup">
<ignore path="AndroidManifest.xml"/>
</issue>
+ <!-- We use asserts in Chromium. See https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md#Asserts -->
<issue id="Assert" severity="ignore"/>
- <!-- TODO(crbug.com/635567): Fix this properly. -->
<issue id="BadHostnameVerifier" severity="Error">
+ <!-- Safe, used in test only. -->
<ignore regexp="net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java"/>
</issue>
<issue id="ButtonOrder" severity="Error">
@@ -73,12 +75,6 @@ Still reading?
</issue>
<issue id="HandlerLeak">
<ignore regexp="android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java" />
- <!-- TODO(crbug.com/635567): Fix this properly. -->
- <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java"/>
- <!-- TODO(crbug.com/635567): Fix this properly. -->
- <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java"/>
- <!-- TODO(crbug.com/635567): Fix this properly. -->
- <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java"/>
<ignore regexp="chromecast/internal" />
<ignore regexp="remoting/android/java/src/org/chromium/chromoting/TapGestureDetector.java" />
</issue>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698