mac: Implement GetStackEnd().

mac: Implement GetStackEnd().

This allows IsStackFrameValid() to correctly use GetStackFramePC() to determine
if a frame has fallen off the end of the stack.

BUG=677302
Review-Url: https://codereview.chromium.org/2707973004
Cr-Commit-Position: refs/heads/master@{#452200}
Committed: https://chromium.googlesource.com/chromium/src/+/d6b2b82cca164cd88ce9f212d4562c01d286973d

[erikchen, 2017-02-21 20:51:11]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org

[erikchen, 2017-02-21 20:51:12]

mark: Please review.

I believe this is the appropriate implementation. pthread_attr_init & co don't
produce the right results. See
https://lists.apple.com/archives/unix-porting/2009/Feb/msg00036.html.

I'm a little bit concerned about this implementation on macOS 10.9, as per
https://github.com/google/sanitizers/issues/261, but that seems to per
constrained to the pthread_get_stacksize_np() function, which I don't use.

[erikchen, 2017-02-21 20:51:15]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 20:52:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 21:12:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:12:38]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[Mark Mentovai, 2017-02-21 22:00:31]

I don’t have much experience with this function because, as you point out, its
sister has historically been broken so I never trusted either. I know that the
sizey one is supposed to have been fixed in 10.10, and Avi and I just checked
that last week and found that it gave the right result in a simple test program.
But since I’ve been avoiding them, I don’t have the direct experience to say
definitively whether this usage is safe. All I can say is that I think it’s
basically safe given what we learned last week, but that was based on
experimentation and not source code inspection.

So that’s an LGTM but it’s also a “keep our fingers crossed.”

[erikchen, 2017-02-21 22:08:51]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2017-02-21 22:08:51]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2707973004/#ps20001
(title: "Fix compile error.")

[commit-bot: I haz the power, 2017-02-21 22:10:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 00:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:15:19]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[erikchen, 2017-02-22 00:44:46]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:45:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 02:49:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 02:49:56]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[erikchen, 2017-02-22 03:00:58]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:03:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 07:27:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 07:27:45]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2017-02-22 18:19:26]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-02-22 18:20:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 21:10:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487787566922860,
"parent_rev": "c85056cd80dd1d75c33b01e236f5bc27dd171c67", "commit_rev":
"d6b2b82cca164cd88ce9f212d4562c01d286973d"}

[commit-bot: I haz the power, 2017-02-22 21:11:14]

Description was changed from

==========
mac: Implement GetStackEnd().

This allows IsStackFrameValid() to correctly use GetStackFramePC() to determine
if a frame has fallen off the end of the stack.

BUG=677302
==========

to

==========
mac: Implement GetStackEnd().

This allows IsStackFrameValid() to correctly use GetStackFramePC() to determine
if a frame has fallen off the end of the stack.

BUG=677302

Review-Url: https://codereview.chromium.org/2707973004
Cr-Commit-Position: refs/heads/master@{#452200}
Committed:
https://chromium.googlesource.com/chromium/src/+/d6b2b82cca164cd88ce9f212d456...
==========

[commit-bot: I haz the power, 2017-02-22 21:11:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d6b2b82cca164cd88ce9f212d456...