bluetooth: Save characteristic value when notification arrives

bluetooth: Save characteristic value when notification arrives

"Once a notification is arrived, work is posted to another thread which
then reads the latest characteristic value. If multiple notifications
arrive fast, this could result in race conditions where all the
onCharacteristicChanged callbacks are first triggered, then the three tasks
posted are executed which all extract the latest notified value instead of
the individual values." -- emil.len...@gmail.com

 [1] Post a task when sending GATT events http://crrev.com/2708513002
 [2.1] Close and null out BluetoothGatt on the UI Thread http://crrev.com/2702163002
 [2.2] Copy characteristic's value before posting task. (This patch).

BUG=647673
Review-Url: https://codereview.chromium.org/2707823002
Cr-Commit-Position: refs/heads/master@{#455037}
Committed: https://chromium.googlesource.com/chromium/src/+/afc9c240ef4f83bf23dfeec704f231f08c5c8121

[ortuno, 2017-02-20 05:56:06]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 05:56:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 06:57:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 06:57:43]

Dry run: This issue passed the CQ dry run.

[ortuno, 2017-02-21 10:45:15]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org

[ortuno, 2017-02-21 10:45:15]

jyasskin: PTAL

[ortuno, 2017-02-27 23:06:57]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org
- jyasskin@chromium.org

[ortuno, 2017-02-27 23:06:57]

scheib: PTAL

[scheib, 2017-03-04 18:54:35]

lgtm

[ortuno, 2017-03-07 03:47:46]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 03:48:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 04:09:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 04:09:28]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ortuno, 2017-03-07 04:18:52]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 04:19:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2017-03-07 05:11:03]

The CQ bit was unchecked by ortuno@chromium.org

[ortuno, 2017-03-07 05:11:08]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2017-03-07 05:11:08]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2707823002/#ps40001
(title: "fix test")

[commit-bot: I haz the power, 2017-03-07 05:12:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 05:21:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488863468410810,
"parent_rev": "31eb5e06008eca25fbd5a937a17c064d1fa7ac83", "commit_rev":
"afc9c240ef4f83bf23dfeec704f231f08c5c8121"}

[commit-bot: I haz the power, 2017-03-07 05:22:56]

Description was changed from

==========
bluetooth: Save characteristic value when notification arrives

"Once a notification is arrived, work is posted to another thread which
then reads the latest characteristic value. If multiple notifications
arrive fast, this could result in race conditions where all the
onCharacteristicChanged callbacks are first triggered, then the three tasks
posted are executed which all extract the latest notified value instead of
the individual values." -- emil.len...@gmail.com

 [1] Post a task when sending GATT events http://crrev.com/2708513002
 [2.1] Close and null out BluetoothGatt on the UI Thread
http://crrev.com/2702163002
 [2.2] Copy characteristic's value before posting task. (This patch).

BUG=647673
==========

to

==========
bluetooth: Save characteristic value when notification arrives

"Once a notification is arrived, work is posted to another thread which
then reads the latest characteristic value. If multiple notifications
arrive fast, this could result in race conditions where all the
onCharacteristicChanged callbacks are first triggered, then the three tasks
posted are executed which all extract the latest notified value instead of
the individual values." -- emil.len...@gmail.com

 [1] Post a task when sending GATT events http://crrev.com/2708513002
 [2.1] Close and null out BluetoothGatt on the UI Thread
http://crrev.com/2702163002
 [2.2] Copy characteristic's value before posting task. (This patch).

BUG=647673

Review-Url: https://codereview.chromium.org/2707823002
Cr-Commit-Position: refs/heads/master@{#455037}
Committed:
https://chromium.googlesource.com/chromium/src/+/afc9c240ef4f83bf23dfeec704f2...
==========

[commit-bot: I haz the power, 2017-03-07 05:22:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/afc9c240ef4f83bf23dfeec704f2...