device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java - Issue 2707823002: bluetooth: Save characteristic value when notification arrives

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java

Issue 2707823002: bluetooth: Save characteristic value when notification arrives (Closed)

Patch Set: fix test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java ('k') | device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java

diff --git a/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java b/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java

index 7d6c50fe381793986e50529a9796adb6cc834da3..fdf6c7b94044076625d298586e22f5215dc97b8b 100644

--- a/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java

+++ b/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java

@@ -58,11 +58,10 @@ final class ChromeBluetoothRemoteGattCharacteristic {

mChromeDevice.mWrapperToChromeCharacteristicsMap.remove(mCharacteristic);

}

- void onCharacteristicChanged() {

+ void onCharacteristicChanged(byte[] value) {

Log.i(TAG, "onCharacteristicChanged");

if (mNativeBluetoothRemoteGattCharacteristicAndroid != 0) {

- nativeOnChanged(

- mNativeBluetoothRemoteGattCharacteristicAndroid, mCharacteristic.getValue());

+ nativeOnChanged(mNativeBluetoothRemoteGattCharacteristicAndroid, value);

}