Capture font-related data in minidump when last resort font failed

Capture font-related data in minidump when last resort font failed

This patch addds FontCache::crashWithInfo() to capture font-related
data when last resort font failed.

BUG=561873
Review-Url: https://codereview.chromium.org/2707763003
Cr-Commit-Position: refs/heads/master@{#451964}
Committed: https://chromium.googlesource.com/chromium/src/+/525ae83ae253451728d18cb115df46197eab35cf

[kojii, 2017-02-20 10:12:43]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 10:13:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-02-20 10:16:41]

Description was changed from

==========
alias

BUG=
==========

to

==========
Capture FontDescription in minidump when last resort font failed

Add debug::alias to capture FontDescription.

BUG=561873
==========

[kojii, 2017-02-20 10:18:36]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-02-20 10:18:37]

PTAL.

The last change didn't seem to help. I wonder if there were any interesting data
in the FontDescription.

[commit-bot: I haz the power, 2017-02-20 11:14:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 11:14:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-02-21 03:04:21]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 03:04:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-02-21 03:09:53]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 03:10:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-02-21 03:12:33]

Patchset #2 (id:20001) has been deleted

[kojii, 2017-02-21 03:14:04]

Description was changed from

==========
Capture FontDescription in minidump when last resort font failed

Add debug::alias to capture FontDescription.

BUG=561873
==========

to

==========
Capture font-related data in minidump when last resort font failed

This patch addds FontCache::crashWithInfo() to capture font-related
data when last resort font failed.

BUG=561873
==========

[kojii, 2017-02-21 03:16:26]

kojii@chromium.org changed reviewers:
+ drott@chromium.org

[kojii, 2017-02-21 03:16:27]

drott@, PTAL. I wasn't aware eae@ is absent.

I'm looking into this recently again, and would like to collect more data.

[kojii, 2017-02-21 03:20:10]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 03:20:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-02-21 03:21:11]

Patchset #2 (id:40001) has been deleted

[kojii, 2017-02-21 03:21:51]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 03:21:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-02-21 03:24:07]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-02-21 05:06:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 05:06:59]

Dry run: This issue passed the CQ dry run.

[eae, 2017-02-21 21:49:59]

LGTM

(yesterday was a public holiday in the US)

[kojii, 2017-02-22 01:15:19]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-02-22 01:16:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-02-22 01:20:31]

> (yesterday was a public holiday in the US)

(oh, thought you're on vacation, where you find the span style= barcode ;)

[commit-bot: I haz the power, 2017-02-22 03:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:19:47]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[kojii, 2017-02-22 03:43:03]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:44:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 05:40:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 05:40:34]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-02-22 05:41:18]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-02-22 05:42:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 07:31:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 07:31:04]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-02-22 08:16:25]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-02-22 08:17:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 10:04:23]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487751385775310,
"parent_rev": "047e3c9956a25ff9ed0391f550f337842cb3e7d6", "commit_rev":
"525ae83ae253451728d18cb115df46197eab35cf"}

[commit-bot: I haz the power, 2017-02-22 10:05:02]

Description was changed from

==========
Capture font-related data in minidump when last resort font failed

This patch addds FontCache::crashWithInfo() to capture font-related
data when last resort font failed.

BUG=561873
==========

to

==========
Capture font-related data in minidump when last resort font failed

This patch addds FontCache::crashWithInfo() to capture font-related
data when last resort font failed.

BUG=561873

Review-Url: https://codereview.chromium.org/2707763003
Cr-Commit-Position: refs/heads/master@{#451964}
Committed:
https://chromium.googlesource.com/chromium/src/+/525ae83ae253451728d18cb115df...
==========

[commit-bot: I haz the power, 2017-02-22 10:05:03]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/525ae83ae253451728d18cb115df...

[drott, 2017-02-22 16:19:01]

That's a good new idea on this subject, thanks for finding out about
crashWithInfo!