Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp

Issue 2707763003: Capture font-related data in minidump when last resort font failed (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/fonts/FontCache.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp b/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
index d082f33aa764c583cdaf11af16b16792407a60d0..3a4bef36ae1a8cca32d700ef5cc793a7a81b1f27 100644
--- a/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
+++ b/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
@@ -116,7 +116,8 @@ PassRefPtr<FontDataForRangeSet> FontFallbackIterator::next(
m_fallbackStage = OutOfLuck;
RefPtr<SimpleFontData> lastResort =
fontCache->getLastResortFallbackFont(m_fontDescription).get();
- RELEASE_ASSERT(lastResort);
+ if (!lastResort)
+ FontCache::crashWithFontInfo(&m_fontDescription);
// Don't skip the LastResort font in uniqueOrNext() since HarfBuzzShaper
// needs to use this one to place missing glyph boxes.
return adoptRef(new FontDataForRangeSetFromCache(lastResort));
« no previous file with comments | « third_party/WebKit/Source/platform/fonts/FontCache.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698