Issue 2707363002: [Offline Pages] Fix storage manager deleting persistent pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2707363002: [Offline Pages] Fix storage manager deleting persistent pages. (Closed)

Created:
3 years, 10 months ago by Dmitry Titov

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

[Offline Pages] Fix storage manager deleting persistent pages. Fixed an issue where persistent pages would be deleted by storage manager when clearing expired pages. BUG=691023 Review-Url: https://codereview.chromium.org/2700563005 Cr-Commit-Position: refs/heads/master@{#451405} (cherry picked from commit 0386b22583a0df497019c2d7d23721f701911b55) Review-Url: https://codereview.chromium.org/2707363002 . Cr-Commit-Position: refs/branch-heads/2987@{#645} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/e1d74d4f8aa6bb7c85858eeed42119aa049643ba

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -9 lines)			Patch
	M	components/offline_pages/core/offline_page_storage_manager.cc	View		3 chunks	+8 lines, -5 lines	0 comments	Download
	M	components/offline_pages/core/offline_page_storage_manager_unittest.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

Dmitry Titov

3 years, 10 months ago (2017-02-22 21:25:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e1d74d4f8aa6bb7c85858eeed42119aa049643ba.