[Offline Pages] Fix storage manager deleting persistent pages.

[Offline Pages] Fix storage manager deleting persistent pages.

Fixed an issue where persistent pages would be deleted by storage manager
when clearing expired pages.

BUG=691023
Review-Url: https://codereview.chromium.org/2700563005
Cr-Commit-Position: refs/heads/master@{#451405}
Committed: https://chromium.googlesource.com/chromium/src/+/0386b22583a0df497019c2d7d23721f701911b55

[romax, 2017-02-17 02:20:57]

romax@chromium.org changed reviewers:
+ carlosk@chromium.org, fgorski@chromium.org

[romax, 2017-02-17 02:20:58]

fgorski@ PTAL
carlosk@ FYI

Thanks!

[romax, 2017-02-17 02:37:55]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 02:39:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 04:42:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 04:42:05]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[fgorski, 2017-02-17 22:44:19]

lgtm

[romax, 2017-02-17 22:45:13]

The CQ bit was checked by romax@chromium.org

[commit-bot: I haz the power, 2017-02-17 22:46:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 23:56:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487371513185750, "parent_rev":
"7da7831727bcb80336d3935ad3da8f95b0e7aebe", "commit_rev":
"0386b22583a0df497019c2d7d23721f701911b55"}

[commit-bot: I haz the power, 2017-02-17 23:57:38]

Description was changed from

==========
[Offline Pages] Fix storage manager deleting persistent pages.

Fixed an issue where persistent pages would be deleted by storage manager
when clearing expired pages.

BUG=691023
==========

to

==========
[Offline Pages] Fix storage manager deleting persistent pages.

Fixed an issue where persistent pages would be deleted by storage manager
when clearing expired pages.

BUG=691023

Review-Url: https://codereview.chromium.org/2700563005
Cr-Commit-Position: refs/heads/master@{#451405}
Committed:
https://chromium.googlesource.com/chromium/src/+/0386b22583a0df497019c2d7d237...
==========

[commit-bot: I haz the power, 2017-02-17 23:57:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0386b22583a0df497019c2d7d237...

[carlosk, 2017-02-23 01:13:39]

Post-fact comments. I'm sorry about that.

https://codereview.chromium.org/2700563005/diff/1/components/offline_pages/co...
File components/offline_pages/core/offline_page_storage_manager_unittest.cc
(right):

https://codereview.chromium.org/2700563005/diff/1/components/offline_pages/co...
components/offline_pages/core/offline_page_storage_manager_unittest.cc:383: //
After more days, all pages should be deleted.
This comment should be updated.

https://codereview.chromium.org/2700563005/diff/1/components/offline_pages/co...
components/offline_pages/core/offline_page_storage_manager_unittest.cc:391:
EXPECT_EQ(131 + 400, static_cast<int>(model()->GetRemovedPages().size()));
And just making sure as it's unclear for me: are there pages flagged as
"persistent" among the survivor ones?

[romax, 2017-02-23 01:31:01]

https://codereview.chromium.org/2700563005/diff/1/components/offline_pages/co...
File components/offline_pages/core/offline_page_storage_manager_unittest.cc
(right):

https://codereview.chromium.org/2700563005/diff/1/components/offline_pages/co...
components/offline_pages/core/offline_page_storage_manager_unittest.cc:383: //
After more days, all pages should be deleted.
On 2017/02/23 01:13:39, carlosk wrote:
> This comment should be updated.

yep should have updated them.. next time :(

https://codereview.chromium.org/2700563005/diff/1/components/offline_pages/co...
components/offline_pages/core/offline_page_storage_manager_unittest.cc:391:
EXPECT_EQ(131 + 400, static_cast<int>(model()->GetRemovedPages().size()));
On 2017/02/23 01:13:39, carlosk wrote:
> And just making sure as it's unclear for me: are there pages flagged as
> "persistent" among the survivor ones?

basically all the survived ones should be persistent, as after 30 days all
temporary ones should be expired already.