Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2707263003: [Autofill] Fast fix of crashes caused by show-autofill-signatures flag. (Closed)

Created:
3 years, 10 months ago by kolos1
Modified:
3 years, 10 months ago
Reviewers:
sebsg
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Fast fix of crashes caused by show-autofill-signatures flag. This CL (https://codereview.chromium.org/2704503002/) caused some crashes. The hidden feature was enabled by default. This CL is a fast fix. I will land the main fix soon (https://codereview.chromium.org/2706403003) BUG=694715 TBR=sebsg@chromium.org Review-Url: https://codereview.chromium.org/2707263003 Cr-Commit-Position: refs/heads/master@{#452037} Committed: https://chromium.googlesource.com/chromium/src/+/319c00e1c8188a7264d674e6bceeb35cb7e6dc63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707263003/1
3 years, 10 months ago (2017-02-22 14:19:24 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 14:24:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/319c00e1c8188a7264d674e6bcee...

Powered by Google App Engine
This is Rietveld 408576698