[Autofill] Fix of crashes caused by show-autofill-signatures flag

[Autofill] Fix of crashes caused by show-autofill-signatures flag

This CL (https://codereview.chromium.org/2704503002/) didn't take into account that |FormData.fields| might be empty if there are more than |kMaxParseableFields|. Also fixed the propagation of show-autofill-signatures flag to the rendered part. Added tests.

BUG=694715
Review-Url: https://codereview.chromium.org/2706403003
Cr-Commit-Position: refs/heads/master@{#452476}
Committed: https://chromium.googlesource.com/chromium/src/+/ad3699385ecc950b3e27ac7ae3754700445887d1

[kolos1, 2017-02-22 16:37:55]

Description was changed from

==========
[Autofill] Fix of failures caused by show-autofill-signatures flag

BUG=694715
==========

to

==========
[Autofill] Fix of failures caused by show-autofill-signatures flag

This CL (https://codereview.chromium.org/2704503002/) didn't take into account
that |FormData.fields| might be empty if there are more than
|kMaxParseableFields|. Also fixed the propagation of show-autofill-signatures
flag to the rendered part. Added tests.

BUG=694715
==========

[kolos1, 2017-02-22 16:38:24]

Description was changed from

==========
[Autofill] Fix of failures caused by show-autofill-signatures flag

This CL (https://codereview.chromium.org/2704503002/) didn't take into account
that |FormData.fields| might be empty if there are more than
|kMaxParseableFields|. Also fixed the propagation of show-autofill-signatures
flag to the rendered part. Added tests.

BUG=694715
==========

to

==========
[Autofill] Fix of crashes caused by show-autofill-signatures flag

This CL (https://codereview.chromium.org/2704503002/) didn't take into account
that |FormData.fields| might be empty if there are more than
|kMaxParseableFields|. Also fixed the propagation of show-autofill-signatures
flag to the rendered part. Added tests.

BUG=694715
==========

[kolos1, 2017-02-22 16:42:52]

Patchset #3 (id:40001) has been deleted

[kolos1, 2017-02-22 16:42:55]

Patchset #1 (id:1) has been deleted

[kolos1, 2017-02-22 16:43:01]

Patchset #1 (id:20001) has been deleted

[kolos1, 2017-02-22 16:43:36]

Patchset #1 (id:60001) has been deleted

[kolos1, 2017-02-22 16:45:58]

kolos@chromium.org changed reviewers:
+ sebsg@chromium.org

[kolos1, 2017-02-22 16:45:59]

Hi Sebastien,

My previous CL (https://codereview.chromium.org/2704503002/) needs several fixes
(see description). Please review.

Regards,
Maxim

[sebsg, 2017-02-22 18:31:44]

LGTM nice test!

[kolos1, 2017-02-23 07:52:35]

The CQ bit was checked by kolos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 07:52:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 07:54:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 07:55:00]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[kolos1, 2017-02-23 08:00:45]

The CQ bit was checked by kolos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 08:01:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 08:02:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 08:03:00]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[kolos1, 2017-02-23 08:15:00]

The CQ bit was unchecked by kolos@chromium.org

[kolos1, 2017-02-23 09:34:29]

The CQ bit was checked by kolos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 09:34:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 09:36:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 09:36:20]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[kolos1, 2017-02-23 09:41:27]

The CQ bit was checked by kolos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 09:41:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 10:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 10:20:22]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kolos1, 2017-02-23 12:24:11]

kolos@chromium.org changed reviewers:
+ mkwst@chromium.org

[kolos1, 2017-02-23 12:24:12]

mkwst@chromium.org: Please review changes in histograms.xml

[kolos1, 2017-02-23 12:24:24]

The CQ bit was checked by kolos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 12:24:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mike West, 2017-02-23 12:39:22]

LGTM

[commit-bot: I haz the power, 2017-02-23 13:18:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 13:18:02]

Dry run: This issue passed the CQ dry run.

[kolos1, 2017-02-23 13:25:22]

The CQ bit was checked by kolos@chromium.org

[kolos1, 2017-02-23 13:25:23]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org
Link to the patchset: https://codereview.chromium.org/2706403003/#ps120001
(title: "Added an entry to histograms.xml")

[commit-bot: I haz the power, 2017-02-23 13:25:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 13:29:46]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487856322840250,
"parent_rev": "c1b23bc6063b682fb4145460711ed38de8ed890e", "commit_rev":
"ad3699385ecc950b3e27ac7ae3754700445887d1"}

[commit-bot: I haz the power, 2017-02-23 13:30:21]

Description was changed from

==========
[Autofill] Fix of crashes caused by show-autofill-signatures flag

This CL (https://codereview.chromium.org/2704503002/) didn't take into account
that |FormData.fields| might be empty if there are more than
|kMaxParseableFields|. Also fixed the propagation of show-autofill-signatures
flag to the rendered part. Added tests.

BUG=694715
==========

to

==========
[Autofill] Fix of crashes caused by show-autofill-signatures flag

This CL (https://codereview.chromium.org/2704503002/) didn't take into account
that |FormData.fields| might be empty if there are more than
|kMaxParseableFields|. Also fixed the propagation of show-autofill-signatures
flag to the rendered part. Added tests.

BUG=694715

Review-Url: https://codereview.chromium.org/2706403003
Cr-Commit-Position: refs/heads/master@{#452476}
Committed:
https://chromium.googlesource.com/chromium/src/+/ad3699385ecc950b3e27ac7ae375...
==========

[commit-bot: I haz the power, 2017-02-23 13:30:22]

Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/ad3699385ecc950b3e27ac7ae375...