[api] Fix DescriptorInterceptor with access check.

[api] Fix DescriptorInterceptor with access check.

The DescriptorInterceptor should intercept all
Object.getOwnPropertyDescriptor calls. This CL fixes
the interceptor's behavior if the iterator state is
ACCESS_CHECK.


BUG=

Review-Url: https://codereview.chromium.org/2707263002
Cr-Commit-Position: refs/heads/master@{#43417}
Committed: https://chromium.googlesource.com/v8/v8/+/0ba513f05696dbf241959b3e0de6a3f8ef2eeab3

[Franzi, 2017-02-22 09:55:21]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 09:55:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 10:21:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 10:21:08]

Dry run: This issue passed the CQ dry run.

[Franzi, 2017-02-22 10:22:48]

franzih@chromium.org changed reviewers:
+ jochen@chromium.org

[Franzi, 2017-02-22 10:22:48]

PTAL. Thanks, 

Franzi

[jochen (gone - plz use gerrit), 2017-02-22 11:02:41]

https://codereview.chromium.org/2707263002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2707263002/diff/1/src/objects.cc#newcode6896
src/objects.cc:6896: if (it->state() == LookupIterator::ACCESS_CHECK) {
hum, if the state is ACCESS_CHECK we should do an access check, and if that one
failed, we need to do a lookup with failed access check (only looking at
AllCanRead properties or using the failed-access-check-interceptor)

[Franzi, 2017-02-22 16:41:04]

The CQ bit was checked by franzih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 16:41:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 17:03:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 17:03:57]

Dry run: This issue passed the CQ dry run.

[Franzi, 2017-02-22 17:38:51]

https://codereview.chromium.org/2707263002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2707263002/diff/1/src/objects.cc#newcode6896
src/objects.cc:6896: if (it->state() == LookupIterator::ACCESS_CHECK) {
On 2017/02/22 11:02:41, jochen wrote:
> hum, if the state is ACCESS_CHECK we should do an access check, and if that
one
> failed, we need to do a lookup with failed access check (only looking at
> AllCanRead properties or using the failed-access-check-interceptor)

I wrongly assumed the interceptor would overrule the access check. 

I changed it to only intercept if has_access() or CanReadAll() is true. If not,
we return and call GetPropertyAttributes() which handles the access check.

[jochen (gone - plz use gerrit), 2017-02-24 15:56:21]

lgtm

[Franzi, 2017-02-24 16:02:15]

The CQ bit was checked by franzih@chromium.org

[commit-bot: I haz the power, 2017-02-24 16:02:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 16:34:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487952135992220,
"parent_rev": "e5f89fa5aed7aabaa8f3482236bd8c36f74a752c", "commit_rev":
"0ba513f05696dbf241959b3e0de6a3f8ef2eeab3"}

[commit-bot: I haz the power, 2017-02-24 16:34:08]

Description was changed from

==========
[api] Fix DescriptorInterceptor with access check.

The DescriptorInterceptor should intercept all
Object.getOwnPropertyDescriptor calls. This CL fixes
the interceptor's behavior if the iterator state is
ACCESS_CHECK.


BUG=
==========

to

==========
[api] Fix DescriptorInterceptor with access check.

The DescriptorInterceptor should intercept all
Object.getOwnPropertyDescriptor calls. This CL fixes
the interceptor's behavior if the iterator state is
ACCESS_CHECK.


BUG=

Review-Url: https://codereview.chromium.org/2707263002
Cr-Commit-Position: refs/heads/master@{#43417}
Committed:
https://chromium.googlesource.com/v8/v8/+/0ba513f05696dbf241959b3e0de6a3f8ef2...
==========

[commit-bot: I haz the power, 2017-02-24 16:34:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/0ba513f05696dbf241959b3e0de6a3f8ef2...