[api] Fix DescriptorInterceptor with access check.

src/objects.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/objects.h"
 
 #include <cmath>
 #include <iomanip>
 #include <memory>
 #include <sstream>
@@ skipping 6875 matching lines @@
   LookupIterator it = LookupIterator::PropertyOrElement(
       isolate, object, key, &success, LookupIterator::OWN);
   DCHECK(success);  // ...so creating a LookupIterator can't fail.
   return GetOwnPropertyDescriptor(&it, desc);
 }
 
 namespace {
 
 Maybe<bool> GetPropertyDescriptorWithInterceptor(LookupIterator* it,
                                                  PropertyDescriptor* desc) {
+  if (it->state() == LookupIterator::ACCESS_CHECK) {

[jochen (gone - plz use gerrit), 2017/02/22 11:02:41]

hum, if the state is ACCESS_CHECK we should do an access check, and if that one
failed, we need to do a lookup with failed access check (only looking at
AllCanRead properties or using the failed-access-check-interceptor)

[Franzi, 2017/02/22 17:38:51]

I wrongly assumed the interceptor would overrule the access check. 

I changed it to only intercept if has_access() or CanReadAll() is true. If not,
we return and call GetPropertyAttributes() which handles the access check. 

+    it->Next();
+  }
+
   if (it->state() == LookupIterator::INTERCEPTOR) {
     Isolate* isolate = it->isolate();
     Handle<InterceptorInfo> interceptor = it->GetInterceptor();
     if (!interceptor->descriptor()->IsUndefined(isolate)) {
       Handle<Object> result;
       Handle<JSObject> holder = it->GetHolder<JSObject>();
 
       Handle<Object> receiver = it->GetReceiver();
       if (!receiver->IsJSReceiver()) {
         ASSIGN_RETURN_ON_EXCEPTION_VALUE(
@@ skipping 24 matching lines @@
         Utils::ApiCheck(
             PropertyDescriptor::ToPropertyDescriptor(isolate, result, desc),
             it->IsElement() ? "v8::IndexedPropertyDescriptorCallback"
                             : "v8::NamedPropertyDescriptorCallback",
             "Invalid property descriptor.");
 
         return Just(true);
       }
     }
   }
+  it->Restart();
   return Just(false);
 }
 }  // namespace
 
 // ES6 9.1.5.1
 // Returns true on success, false if the property didn't exist, nothing if
 // an exception was thrown.
 // static
 Maybe<bool> JSReceiver::GetOwnPropertyDescriptor(LookupIterator* it,
                                                  PropertyDescriptor* desc) {
@@ skipping 13132 matching lines @@
       // depend on this.
       return DICTIONARY_ELEMENTS;
     }
     DCHECK_LE(kind, LAST_ELEMENTS_KIND);
     return kind;
   }
 }
 
 }  // namespace internal
 }  // namespace v8