third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp - Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)

Patch Set: update comment, add TODO Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp b/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

index f6965ea6e22840fb54314347e87d2d5af34c14e8..d8b76c55332dfca62af10902910809575a837979 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

@@ -32,9 +32,10 @@ PushMessageData* PushMessageData::Create(const String& message_string) {

PushMessageData* PushMessageData::Create(

const ArrayBufferOrArrayBufferViewOrUSVString& message_data) {

if (message_data.isArrayBuffer() || message_data.isArrayBufferView()) {

- DOMArrayBuffer* buffer = message_data.isArrayBufferView()

- ? message_data.getAsArrayBufferView()->buffer()

- : message_data.getAsArrayBuffer();

+ DOMArrayBuffer* buffer =

+ message_data.isArrayBufferView()

+ ? message_data.getAsArrayBufferView().View()->buffer()

+ : message_data.getAsArrayBuffer();

return new PushMessageData(static_cast<const char*>(buffer->Data()),

buffer->ByteLength());