third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp - Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)

Patch Set: update comment, add TODO Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationConnection.h ('k') | third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

index a4d35a35cc5170cc89f1904eaf3cfc33b3e2991b..eb045a64e890c8106ca19b9a03c2c4fa34fcfb8a 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

@@ -282,13 +282,14 @@ void PresentationConnection::send(DOMArrayBuffer* array_buffer,

HandleMessageQueue();

}

-void PresentationConnection::send(DOMArrayBufferView* array_buffer_view,

- ExceptionState& exception_state) {

- ASSERT(array_buffer_view);

+void PresentationConnection::send(

+ NotShared<DOMArrayBufferView> array_buffer_view,

+ ExceptionState& exception_state) {

+ DCHECK(array_buffer_view);

if (!CanSendMessage(exception_state))

return;

- messages_.push_back(new Message(array_buffer_view->buffer()));

+ messages_.push_back(new Message(array_buffer_view.View()->buffer()));

HandleMessageQueue();

}