third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp - Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)

Patch Set: update comment, add TODO Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp ('k') | third_party/WebKit/Source/modules/sensor/OrientationSensor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp b/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp

index 9c25e437447fd9fb598209af3f3209b8116b8a8c..3700e538cbf8a4673da4643c6c2d4edf6f73f1f5 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp

@@ -31,9 +31,11 @@ String BufferSourceToString(

length = application_server_key.getAsArrayBuffer()->ByteLength();

} else if (application_server_key.isArrayBufferView()) {

input = static_cast<unsigned char*>(

- application_server_key.getAsArrayBufferView()->buffer()->Data());

- length =

- application_server_key.getAsArrayBufferView()->buffer()->ByteLength();

+ application_server_key.getAsArrayBufferView().View()->buffer()->Data());

+ length = application_server_key.getAsArrayBufferView()

+ .View()

+ ->buffer()

+ ->ByteLength();

} else {

NOTREACHED();

return String();