Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2707193004: Remove unnecessary PagePool locks. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary PagePool locks. With per-thread heap (arenas), there will not be any contention on adding and removing page pool entries. R=haraken BUG=671856 Review-Url: https://codereview.chromium.org/2707193004 Cr-Commit-Position: refs/heads/master@{#452023} Committed: https://chromium.googlesource.com/chromium/src/+/befbcdf4f36ecd0f2cbc58687bdc9c854156c49e

Patch Set 1 #

Patch Set 2 : remove now-redundant include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/heap/PagePool.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PagePool.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sof
please take a look.
3 years, 10 months ago (2017-02-22 10:32:06 UTC) #4
haraken
LGTM
3 years, 10 months ago (2017-02-22 10:33:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707193004/20001
3 years, 10 months ago (2017-02-22 11:48:36 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 13:13:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/befbcdf4f36ecd0f2cbc58687bdc...

Powered by Google App Engine
This is Rietveld 408576698