[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
Review-Url: https://codereview.chromium.org/2707163003
Cr-Commit-Position: refs/heads/master@{#451895}
Committed: https://chromium.googlesource.com/chromium/src/+/e63ee2d8631859f96c552a203469b13a3fcceaee

[ymzhang1, 2017-02-21 21:24:14]

Patchset #1 (id:1) has been deleted

[ymzhang1, 2017-02-21 21:25:00]

ymzhang@chromium.org changed reviewers:
+ rsesek@chromium.org

[ymzhang1, 2017-02-21 21:25:01]

Hello,

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS files? Thank you very much!

[Robert Sesek, 2017-02-21 21:47:57]

https://codereview.chromium.org/2707163003/diff/20001/build/config/mac/OWNERS
File build/config/mac/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/20001/build/config/mac/OWNERS...
build/config/mac/OWNERS:4: # COMPONENT: Infra>Platform>Config
Build

https://codereview.chromium.org/2707163003/diff/20001/components/safe_json/OW...
File components/safe_json/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/20001/components/safe_json/OW...
components/safe_json/OWNERS:4: # COMPONENT: UI>Browser>SafeBrowsing
Internals>Core

https://codereview.chromium.org/2707163003/diff/20001/components/web_resource...
File components/web_resource/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/20001/components/web_resource...
components/web_resource/OWNERS:9: # COMPONENT: Internals>Network
This doesn't really have a component.

https://codereview.chromium.org/2707163003/diff/20001/ios/chrome/browser/web_...
File ios/chrome/browser/web_resource/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/20001/ios/chrome/browser/web_...
ios/chrome/browser/web_resource/OWNERS:5: # COMPONENT: Test>iOS
This isn't right.

https://codereview.chromium.org/2707163003/diff/20001/third_party/apple_sampl...
File third_party/apple_sample_code/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/20001/third_party/apple_sampl...
third_party/apple_sample_code/OWNERS:4: # COMPONENT: Infra>Platform>Config
Not right.

https://codereview.chromium.org/2707163003/diff/20001/third_party/ocmock/OWNERS
File third_party/ocmock/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/20001/third_party/ocmock/OWNE...
third_party/ocmock/OWNERS:4: # COMPONENT: ChromeForWork
Test

[ymzhang1, 2017-02-21 21:57:38]

Patchset #2 (id:40001) has been deleted

[ymzhang1, 2017-02-21 22:01:04]

Patchset #2 (id:60001) has been deleted

[ymzhang1, 2017-02-21 22:07:43]

Patchset #3 (id:100001) has been deleted

[ymzhang1, 2017-02-21 22:07:49]

Patchset #2 (id:80001) has been deleted

[ymzhang1, 2017-02-21 22:08:10]

https://codereview.chromium.org/2707163003/diff/20001/build/config/mac/OWNERS
File build/config/mac/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/20001/build/config/mac/OWNERS...
build/config/mac/OWNERS:4: # COMPONENT: Infra>Platform>Config
On 2017/02/21 21:47:57, Robert Sesek wrote:
> Build

Done.

https://codereview.chromium.org/2707163003/diff/20001/components/safe_json/OW...
File components/safe_json/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/20001/components/safe_json/OW...
components/safe_json/OWNERS:4: # COMPONENT: UI>Browser>SafeBrowsing
On 2017/02/21 21:47:57, Robert Sesek wrote:
> Internals>Core

Done.

https://codereview.chromium.org/2707163003/diff/20001/components/web_resource...
File components/web_resource/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/20001/components/web_resource...
components/web_resource/OWNERS:9: # COMPONENT: Internals>Network
On 2017/02/21 21:47:57, Robert Sesek wrote:
> This doesn't really have a component.

Done.

https://codereview.chromium.org/2707163003/diff/20001/ios/chrome/browser/web_...
File ios/chrome/browser/web_resource/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/20001/ios/chrome/browser/web_...
ios/chrome/browser/web_resource/OWNERS:5: # COMPONENT: Test>iOS
On 2017/02/21 21:47:57, Robert Sesek wrote:
> This isn't right.

Done.

https://codereview.chromium.org/2707163003/diff/20001/third_party/apple_sampl...
File third_party/apple_sample_code/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/20001/third_party/apple_sampl...
third_party/apple_sample_code/OWNERS:4: # COMPONENT: Infra>Platform>Config
On 2017/02/21 21:47:57, Robert Sesek wrote:
> Not right.

Done.

https://codereview.chromium.org/2707163003/diff/20001/third_party/ocmock/OWNERS
File third_party/ocmock/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/20001/third_party/ocmock/OWNE...
third_party/ocmock/OWNERS:4: # COMPONENT: ChromeForWork
On 2017/02/21 21:47:57, Robert Sesek wrote:
> Test

Done.

[Robert Sesek, 2017-02-21 22:17:21]

https://codereview.chromium.org/2707163003/diff/120001/components/safe_json/O...
File components/safe_json/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/120001/components/safe_json/O...
components/safe_json/OWNERS:4: # TEAM: layout-dev@chromium.org
Replace this with security-dev

[ymzhang1, 2017-02-21 22:32:05]

https://codereview.chromium.org/2707163003/diff/120001/components/safe_json/O...
File components/safe_json/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/120001/components/safe_json/O...
components/safe_json/OWNERS:4: # TEAM: layout-dev@chromium.org
On 2017/02/21 22:17:21, Robert Sesek wrote:
> Replace this with security-dev

We would like to have at most one team for each component. And this team will be
the primary team to triage the component. 

Currently we have layout-dev@ for Internals>Core. 

And security-dev@ is for component Blink>SecurityFeature and Internals>Sandbox.

Another option would be only have team information in this OWNERS.

[Robert Sesek, 2017-02-21 22:37:37]

https://codereview.chromium.org/2707163003/diff/120001/components/safe_json/O...
File components/safe_json/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/120001/components/safe_json/O...
components/safe_json/OWNERS:4: # TEAM: layout-dev@chromium.org
On 2017/02/21 22:32:05, ymzhang1 wrote:
> On 2017/02/21 22:17:21, Robert Sesek wrote:
> > Replace this with security-dev
> 
> We would like to have at most one team for each component. And this team will
be
> the primary team to triage the component. 
> 
> Currently we have layout-dev@ for Internals>Core. 

That is not the correct meaning for Internals>Core. Per the tracker,
"Internals>Core  = Everything else (IPC, multi-process, memory, breakpad,
sandbox)" -- so it's a catch-all. layout-dev@ seems highly Blink-specific for
that.

> And security-dev@ is for component Blink>SecurityFeature and
Internals>Sandbox.

Neither of those is appropriate.

> Another option would be only have team information in this OWNERS.  

Maybe this then.

[ymzhang1, 2017-02-21 22:44:14]

https://codereview.chromium.org/2707163003/diff/120001/components/safe_json/O...
File components/safe_json/OWNERS (right):

https://codereview.chromium.org/2707163003/diff/120001/components/safe_json/O...
components/safe_json/OWNERS:4: # TEAM: layout-dev@chromium.org
On 2017/02/21 22:37:36, Robert Sesek wrote:
> On 2017/02/21 22:32:05, ymzhang1 wrote:
> > On 2017/02/21 22:17:21, Robert Sesek wrote:
> > > Replace this with security-dev
> > 
> > We would like to have at most one team for each component. And this team
will
> be
> > the primary team to triage the component. 
> > 
> > Currently we have layout-dev@ for Internals>Core. 
> 
> That is not the correct meaning for Internals>Core. Per the tracker,
> "Internals>Core  = Everything else (IPC, multi-process, memory, breakpad,
> sandbox)" -- so it's a catch-all. layout-dev@ seems highly Blink-specific for
> that.
> 
> > And security-dev@ is for component Blink>SecurityFeature and
> Internals>Sandbox.
> 
> Neither of those is appropriate.
> 
> > Another option would be only have team information in this OWNERS.  
> 
> Maybe this then.

Got it. Thanks for pointing this out. I'd better update this mapping on my list.
I'll only add team information in this OWNERS for now. Thanks!

[Robert Sesek, 2017-02-21 22:54:40]

LGTM

[ymzhang1, 2017-02-21 22:55:22]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-02-21 22:56:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 00:59:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:59:15]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[ymzhang1, 2017-02-22 03:59:51]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-02-22 04:00:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 05:57:44]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1487735991871810,
"parent_rev": "e04626f9a5673a92427e6288b16851d8f1d16cd9", "commit_rev":
"e63ee2d8631859f96c552a203469b13a3fcceaee"}

[commit-bot: I haz the power, 2017-02-22 05:58:40]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905

Review-Url: https://codereview.chromium.org/2707163003
Cr-Commit-Position: refs/heads/master@{#451895}
Committed:
https://chromium.googlesource.com/chromium/src/+/e63ee2d8631859f96c552a203469...
==========

[commit-bot: I haz the power, 2017-02-22 05:58:41]

Committed patchset #3 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/e63ee2d8631859f96c552a203469...