components/safe_json/OWNERS - Issue 2707163003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/safe_json/OWNERS

Issue 2707163003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Patch Set: update component Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 bauerb@chromium.org	1 bauerb@chromium.org

2 rsesek@chromium.org	2 rsesek@chromium.org

	3

	4 # TEAM: layout-dev@chromium.org
	Robert Sesek 2017/02/21 22:17:21 Replace this with security-dev Replace this with security-dev ymzhang1 2017/02/21 22:32:05 We would like to have at most one team for each co Show quoted text On 2017/02/21 22:17:21, Robert Sesek wrote: > Replace this with security-dev We would like to have at most one team for each component. And this team will be the primary team to triage the component. Currently we have layout-dev@ for Internals>Core. And security-dev@ is for component Blink>SecurityFeature and Internals>Sandbox. Another option would be only have team information in this OWNERS. Robert Sesek 2017/02/21 22:37:36 That is not the correct meaning for Internals>Core Show quoted text On 2017/02/21 22:32:05, ymzhang1 wrote: > On 2017/02/21 22:17:21, Robert Sesek wrote: > > Replace this with security-dev > > We would like to have at most one team for each component. And this team will be > the primary team to triage the component. > > Currently we have layout-dev@ for Internals>Core. That is not the correct meaning for Internals>Core. Per the tracker, "Internals>Core = Everything else (IPC, multi-process, memory, breakpad, sandbox)" -- so it's a catch-all. layout-dev@ seems highly Blink-specific for that. Show quoted text > And security-dev@ is for component Blink>SecurityFeature and Internals>Sandbox. Neither of those is appropriate. Show quoted text > Another option would be only have team information in this OWNERS. Maybe this then. ymzhang1 2017/02/21 22:44:14 Got it. Thanks for pointing this out. I'd better u Show quoted text On 2017/02/21 22:37:36, Robert Sesek wrote: > On 2017/02/21 22:32:05, ymzhang1 wrote: > > On 2017/02/21 22:17:21, Robert Sesek wrote: > > > Replace this with security-dev > > > > We would like to have at most one team for each component. And this team will > be > > the primary team to triage the component. > > > > Currently we have layout-dev@ for Internals>Core. > > That is not the correct meaning for Internals>Core. Per the tracker, > "Internals>Core = Everything else (IPC, multi-process, memory, breakpad, > sandbox)" -- so it's a catch-all. layout-dev@ seems highly Blink-specific for > that. > > > And security-dev@ is for component Blink>SecurityFeature and > Internals>Sandbox. > > Neither of those is appropriate. > > > Another option would be only have team information in this OWNERS. > > Maybe this then. Got it. Thanks for pointing this out. I'd better update this mapping on my list. I'll only add team information in this OWNERS for now. Thanks!
	5 # COMPONENT: Internals>Core

OLD	NEW

« no previous file with comments | « components/crash/core/OWNERS ('k') | third_party/ocmock/OWNERS » ('j') | no next file with comments »