Remove the text blob cache

Remove the text blob cache

SlimmingPaint display list item caching provides the same level of
SkTextBlob persistence.

BUG=694609
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2707083002
Cr-Commit-Position: refs/heads/master@{#452318}
Committed: https://chromium.googlesource.com/chromium/src/+/6f057b93cf230adadd55af0490c836d91ba6e1fd

[f(malita), 2017-02-21 18:00:57]

Description was changed from

==========
Remove the text blob cache

SlimmingPaint display list item caching provides the same level of
SkTextBlob persistence.

BUG=694609
==========

to

==========
Remove the text blob cache

SlimmingPaint display list item caching provides the same level of
SkTextBlob persistence.

BUG=694609
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[f(malita), 2017-02-21 18:01:09]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 18:01:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 20:14:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 20:14:49]

Dry run: This issue passed the CQ dry run.

[f(malita), 2017-02-22 19:11:14]

Description was changed from

==========
Remove the text blob cache

SlimmingPaint display list item caching provides the same level of
SkTextBlob persistence.

BUG=694609
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove the text blob cache

SlimmingPaint display list item caching provides the same level of
SkTextBlob persistence.

BUG=694609
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[f(malita), 2017-02-22 19:11:14]

fmalita@chromium.org changed reviewers:
+ chrishtr@chromium.org, drott@chromium.org, eae@chromium.org,
jbroman@chromium.org, pdr@chromium.org

[f(malita), 2017-02-22 19:22:49]

Cluster Telemetry 10k run:
https://storage.cloud.google.com/cluster-telemetry/tasks/chromium_perf_runs/f...

Numbers look as expected:

 * no change (within noise levels) for normal record/raster times (SP cache
filling in for the blob cache, as expected)
 * 45% slower record_time_caching_disabled (the effect of removing the blob
cache + disabling the SP cache => rebuilding blobs on every re-record)
 * slightly better (2-3%) record_time_construction_disabled and
record_time_painting_disabled (the effect of removing blob cache
management/lookups?)


Fieldname                                     Total           Total w/Patch   %
Change	%Difference
record_time_caching_disabled (ms)             12193.210       17725.644	     
45.373%  36.983%
pixels_rasterized (pixels)                    14819107174.300 14826363019.700 
0.049%   0.049%
pixels_recorded (pixels)                      51943570331.200 51921176618.500
-0.043%  -0.043%
viewport_picture_size (bytes)                 2040032090.670  2038826386.670 
-0.059%  -0.059%
rasterize_time (ms)                           39002.418       38954.304      
-0.123%  -0.123%
record_time_subsequence_caching_disabled (ms) 4318.758        4291.314       
-0.635%  -0.638%
record_time_partial_invalidation_ms (ms)      439.040         435.755        
-0.748%  -0.751%
record_time (ms)                              469.685         465.853        
-0.816%  -0.819%
record_time_construction_disabled (ms)        5347.462        5232.286       
-2.154%  -2.177%
record_time_painting_disabled (ms)            7618.570        7380.790       
-3.121%  -3.171%

[jbroman, 2017-02-22 19:30:02]

I'll leave this to the paint team. Seems reasonable to me, as long as we are
confident that the SP cache will handle 90%+ of the cases the text blob cache
would have (as IIRC it can be a little more coarse in some places).

[eae, 2017-02-22 20:37:13]

LGTM for fonts code. Thank you, any change that removes a cache has me excited!

[drott, 2017-02-22 20:41:26]

Thanks for doing this, great work on more cache slashing! Same here,
platform/fonts/* changes LGTM++.

[pdr., 2017-02-22 21:02:24]

LGTM

[f(malita), 2017-02-22 22:21:43]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2017-02-22 22:22:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 00:55:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487802103775260, "parent_rev":
"aaa73ea0f5ac4aadf0f30e12a3e86fa3388ec1be", "commit_rev":
"6f057b93cf230adadd55af0490c836d91ba6e1fd"}

[commit-bot: I haz the power, 2017-02-23 00:55:41]

Description was changed from

==========
Remove the text blob cache

SlimmingPaint display list item caching provides the same level of
SkTextBlob persistence.

BUG=694609
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove the text blob cache

SlimmingPaint display list item caching provides the same level of
SkTextBlob persistence.

BUG=694609
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2707083002
Cr-Commit-Position: refs/heads/master@{#452318}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f057b93cf230adadd55af0490c8...
==========

[commit-bot: I haz the power, 2017-02-23 00:55:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6f057b93cf230adadd55af0490c8...