Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2707083002: Remove the text blob cache (Closed)

Created:
3 years, 10 months ago by f(malita)
Modified:
3 years, 10 months ago
Reviewers:
drott, chrishtr, eae, pdr., jbroman
CC:
jbroman, ajuma+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, fmalita+watch_chromium.org, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, reed1, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the text blob cache SlimmingPaint display list item caching provides the same level of SkTextBlob persistence. BUG=694609 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2707083002 Cr-Commit-Position: refs/heads/master@{#452318} Committed: https://chromium.googlesource.com/chromium/src/+/6f057b93cf230adadd55af0490c836d91ba6e1fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -111 lines) Patch
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 3 chunks +3 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.h View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.cpp View 2 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.cpp View 10 chunks +5 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/platform/fonts/TextBlob.h View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextRun.h View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
f(malita)
Cluster Telemetry 10k run: https://storage.cloud.google.com/cluster-telemetry/tasks/chromium_perf_runs/fmalita-20170222033316/html/index.html Numbers look as expected: * no change (within noise levels) ...
3 years, 10 months ago (2017-02-22 19:22:49 UTC) #8
jbroman
I'll leave this to the paint team. Seems reasonable to me, as long as we ...
3 years, 10 months ago (2017-02-22 19:30:02 UTC) #9
eae
LGTM for fonts code. Thank you, any change that removes a cache has me excited!
3 years, 10 months ago (2017-02-22 20:37:13 UTC) #10
drott
Thanks for doing this, great work on more cache slashing! Same here, platform/fonts/* changes LGTM++.
3 years, 10 months ago (2017-02-22 20:41:26 UTC) #11
pdr.
LGTM
3 years, 10 months ago (2017-02-22 21:02:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707083002/1
3 years, 10 months ago (2017-02-22 22:22:21 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 00:55:43 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6f057b93cf230adadd55af0490c8...

Powered by Google App Engine
This is Rietveld 408576698