Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: third_party/WebKit/Source/core/paint/TextPainter.cpp

Issue 2707083002: Remove the text blob cache (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/TextPainter.h ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/TextPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/TextPainter.cpp b/third_party/WebKit/Source/core/paint/TextPainter.cpp
index 6529fb43ec220d404436a3ac8e003f49b451d959..d4d942d6c1577d9b3176ba6a2e5ef59ebef76917 100644
--- a/third_party/WebKit/Source/core/paint/TextPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/TextPainter.cpp
@@ -62,18 +62,17 @@ void TextPainter::setEmphasisMark(const AtomicString& emphasisMark,
void TextPainter::paint(unsigned startOffset,
unsigned endOffset,
unsigned length,
- const Style& textStyle,
- TextBlobPtr* cachedTextBlob) {
+ const Style& textStyle) {
GraphicsContextStateSaver stateSaver(m_graphicsContext, false);
updateGraphicsContext(textStyle, stateSaver);
if (m_combinedText) {
m_graphicsContext.save();
m_combinedText->transformToInlineCoordinates(m_graphicsContext,
m_textBounds);
- paintInternal<PaintText>(startOffset, endOffset, length, cachedTextBlob);
+ paintInternal<PaintText>(startOffset, endOffset, length);
m_graphicsContext.restore();
} else {
- paintInternal<PaintText>(startOffset, endOffset, length, cachedTextBlob);
+ paintInternal<PaintText>(startOffset, endOffset, length);
}
if (!m_emphasisMark.isEmpty()) {
@@ -238,13 +237,10 @@ void TextPainter::paintInternalRun(TextRunPaintInfo& textRunPaintInfo,
template <TextPainter::PaintInternalStep Step>
void TextPainter::paintInternal(unsigned startOffset,
unsigned endOffset,
- unsigned truncationPoint,
- TextBlobPtr* cachedTextBlob) {
+ unsigned truncationPoint) {
TextRunPaintInfo textRunPaintInfo(m_run);
textRunPaintInfo.bounds = FloatRect(m_textBounds);
if (startOffset <= endOffset) {
- // FIXME: We should be able to use cachedTextBlob in more cases.
- textRunPaintInfo.cachedTextBlob = cachedTextBlob;
paintInternalRun<Step>(textRunPaintInfo, startOffset, endOffset);
} else {
if (endOffset > 0)
« no previous file with comments | « third_party/WebKit/Source/core/paint/TextPainter.h ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698