Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1829)

Issue 2707053006: Allow a preconnecting job to a HTTP2 proxy server based on privacy mode (Closed)

Created:
3 years, 10 months ago by tbansal1
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Allow a preconnecting job to a HTTP2 proxy server based on privacy mode Currently, one preconnect job is allowed in-flight for one proxy server. This CL changes it to allow one in-flight preconnect job for one (proxy server, privacy mode) tuple. This is needed since requests that use different privacy modes cannot share the same connection. BUG=667471 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2648593002 Cr-Commit-Position: refs/heads/master@{#445392} (cherry picked from commit 37e33d58c076a55df84e0187538d6ec8996c206b) Review-Url: https://codereview.chromium.org/2707053006 . Cr-Commit-Position: refs/branch-heads/2987@{#649} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/9de7914b0e652585d4ac07303a949fbf1b19f09c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -12 lines) Patch
M net/http/http_stream_factory_impl.h View 4 chunks +22 lines, -5 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 4 chunks +29 lines, -5 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 5 chunks +7 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 3 chunks +85 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tbansal1
3 years, 10 months ago (2017-02-22 23:26:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9de7914b0e652585d4ac07303a949fbf1b19f09c.

Powered by Google App Engine
This is Rietveld 408576698