Allow a preconnecting job to a HTTP2 proxy server based on privacy mode

Allow a preconnecting job to a HTTP2 proxy server based on privacy mode

Currently, one preconnect job is allowed in-flight for one proxy server.
This CL changes it to allow one in-flight preconnect job for one
(proxy server, privacy mode) tuple. This is needed since requests that
use different privacy modes cannot share the same connection.

BUG=667471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2648593002
Cr-Commit-Position: refs/heads/master@{#445392}
Committed: https://chromium.googlesource.com/chromium/src/+/37e33d58c076a55df84e0187538d6ec8996c206b

[tbansal1, 2017-01-19 21:25:35]

Description was changed from

==========
Allow a preconnecting job with a different privacy mode

BUG=
==========

to

==========
Allow a preconnecting job to a HTTP2 proxy server based on privacy mode

BUG=667471
==========

[tbansal1, 2017-01-19 21:35:40]

Description was changed from

==========
Allow a preconnecting job to a HTTP2 proxy server based on privacy mode

BUG=667471
==========

to

==========
Allow a preconnecting job to a HTTP2 proxy server based on privacy mode

Currently, one preconnect job is allowed in-flight for one proxy server.
This CL changes it to allow one in-flight preconnect job for one
(proxy server, privacy mode) tuple.

BUG=667471
==========

[tbansal1, 2017-01-19 21:36:05]

Description was changed from

==========
Allow a preconnecting job to a HTTP2 proxy server based on privacy mode

Currently, one preconnect job is allowed in-flight for one proxy server.
This CL changes it to allow one in-flight preconnect job for one
(proxy server, privacy mode) tuple.

BUG=667471
==========

to

==========
Allow a preconnecting job to a HTTP2 proxy server based on privacy mode

Currently, one preconnect job is allowed in-flight for one proxy server.
This CL changes it to allow one in-flight preconnect job for one
(proxy server, privacy mode) tuple. This is needed since requests that
use different privacy modes cannot share the same connection.

BUG=667471
==========

[tbansal1, 2017-01-19 21:53:07]

Patchset #2 (id:20001) has been deleted

[tbansal1, 2017-01-19 21:53:14]

Patchset #1 (id:1) has been deleted

[tbansal1, 2017-01-19 21:53:27]

tbansal@chromium.org changed reviewers:
+ rch@chromium.org

[tbansal1, 2017-01-19 21:53:28]

rch: ptal. thanks.

[tbansal1, 2017-01-19 22:02:48]

Description was changed from

==========
Allow a preconnecting job to a HTTP2 proxy server based on privacy mode

Currently, one preconnect job is allowed in-flight for one proxy server.
This CL changes it to allow one in-flight preconnect job for one
(proxy server, privacy mode) tuple. This is needed since requests that
use different privacy modes cannot share the same connection.

BUG=667471
==========

to

==========
Allow a preconnecting job to a HTTP2 proxy server based on privacy mode

Currently, one preconnect job is allowed in-flight for one proxy server.
This CL changes it to allow one in-flight preconnect job for one
(proxy server, privacy mode) tuple. This is needed since requests that
use different privacy modes cannot share the same connection.

BUG=667471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-01-19 22:02:57]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 22:03:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 22:07:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 22:07:43]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ryan Hamilton, 2017-01-22 16:22:34]

lgtm

nice catch

https://codereview.chromium.org/2648593002/diff/40001/net/http/http_stream_fa...
File net/http/http_stream_factory_impl_unittest.cc (right):

https://codereview.chromium.org/2648593002/diff/40001/net/http/http_stream_fa...
net/http/http_stream_factory_impl_unittest.cc:1317: // than that of the
in-flight preconnect job succeeds.
Presumably, the existing tests cover the case of the same proxy mode, right?

[tbansal1, 2017-01-23 01:37:50]

https://codereview.chromium.org/2648593002/diff/40001/net/http/http_stream_fa...
File net/http/http_stream_factory_impl_unittest.cc (right):

https://codereview.chromium.org/2648593002/diff/40001/net/http/http_stream_fa...
net/http/http_stream_factory_impl_unittest.cc:1317: // than that of the
in-flight preconnect job succeeds.
On 2017/01/22 16:22:34, Ryan Hamilton wrote:
> Presumably, the existing tests cover the case of the same proxy mode, right?

Yes, they do. Additionally, in this new test, I create 3 requests where 2 have
the same privacy mode, and third has a different mode. So, this test also covers
the case of same proxy mode.

[tbansal1, 2017-01-23 01:37:56]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2017-01-23 01:38:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 03:23:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 03:23:10]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tbansal1, 2017-01-23 16:04:33]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2017-01-23 16:04:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 17:02:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485187473319380,
"parent_rev": "5c82ff8b58da4705c274c86201144268eb54090c", "commit_rev":
"37e33d58c076a55df84e0187538d6ec8996c206b"}

[commit-bot: I haz the power, 2017-01-23 17:02:53]

Description was changed from

==========
Allow a preconnecting job to a HTTP2 proxy server based on privacy mode

Currently, one preconnect job is allowed in-flight for one proxy server.
This CL changes it to allow one in-flight preconnect job for one
(proxy server, privacy mode) tuple. This is needed since requests that
use different privacy modes cannot share the same connection.

BUG=667471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Allow a preconnecting job to a HTTP2 proxy server based on privacy mode

Currently, one preconnect job is allowed in-flight for one proxy server.
This CL changes it to allow one in-flight preconnect job for one
(proxy server, privacy mode) tuple. This is needed since requests that
use different privacy modes cannot share the same connection.

BUG=667471
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2648593002
Cr-Commit-Position: refs/heads/master@{#445392}
Committed:
https://chromium.googlesource.com/chromium/src/+/37e33d58c076a55df84e0187538d...
==========

[commit-bot: I haz the power, 2017-01-23 17:02:54]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/37e33d58c076a55df84e0187538d...