components/flags_ui/feature_entry.h - Issue 2707013002: [chrome://flags] Let features override params in the same trial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/flags_ui/feature_entry.h

Issue 2707013002: [chrome://flags] Let features override params in the same trial (Closed)

Patch Set: Comments #2 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/flags_ui/feature_entry.h

diff --git a/components/flags_ui/feature_entry.h b/components/flags_ui/feature_entry.h

index d61ba843815453bc18e98621b8aca998d36e9d5a..86e14c7a2985bdc85dea7a23e92d7af339bafcb4 100644

--- a/components/flags_ui/feature_entry.h

+++ b/components/flags_ui/feature_entry.h

@@ -147,7 +147,9 @@ struct FeatureEntry {

const char* disable_command_line_switch;

const char* disable_command_line_value;

- // For FEATURE_VALUE, the base::Feature this entry corresponds to.

+ // For FEATURE_VALUE or FEATURE_WITH_VARIATIONS_VALUE, the base::Feature this

+ // entry corresponds to. The same feature must not be used in multiple

+ // FeatureEntries.

const base::Feature* feature;

// Number of options to choose from. This is used if type is MULTI_VALUE,

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/flags_ui/feature_entry_macros.h » ('j') | no next file with comments »