components/flags_ui/feature_entry_macros.h - Issue 2707013002: [chrome://flags] Let features override params in the same trial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/flags_ui/feature_entry_macros.h

Issue 2707013002: [chrome://flags] Let features override params in the same trial (Closed)

Patch Set: Comments #2 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/flags_ui/feature_entry_macros.h

diff --git a/components/flags_ui/feature_entry_macros.h b/components/flags_ui/feature_entry_macros.h

index f83ce31252f17330129056e68c4a160613585759..530fbc595b5403ce14be45192277358d2dbfc783 100644

--- a/components/flags_ui/feature_entry_macros.h

+++ b/components/flags_ui/feature_entry_macros.h

@@ -32,6 +32,7 @@

#define FEATURE_VALUE_TYPE(feature) \

flags_ui::FeatureEntry::FEATURE_VALUE, nullptr, nullptr, nullptr, nullptr, \

&feature, 3, nullptr, nullptr, nullptr

+// TODO(jkrcal): Rename FEATURE_WITH_VARIATIONS* to FEATURE_WITH_PARAMS*.

#define FEATURE_WITH_VARIATIONS_VALUE_TYPE(feature, feature_variations, \

feature_trial) \

flags_ui::FeatureEntry::FEATURE_WITH_VARIATIONS_VALUE, nullptr, nullptr, \

« no previous file with comments | « components/flags_ui/feature_entry.h ('k') | components/flags_ui/flags_state.cc » ('j') | no next file with comments »