Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: components/flags_ui/feature_entry.h

Issue 2707013002: [chrome://flags] Let features override params in the same trial (Closed)
Patch Set: Comments #2 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/flags_ui/feature_entry_macros.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FLAGS_UI_FEATURE_ENTRY_H_ 5 #ifndef COMPONENTS_FLAGS_UI_FEATURE_ENTRY_H_
6 #define COMPONENTS_FLAGS_UI_FEATURE_ENTRY_H_ 6 #define COMPONENTS_FLAGS_UI_FEATURE_ENTRY_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 const char* command_line_switch; 140 const char* command_line_switch;
141 141
142 // Simple switches that have no value should use "" for command_line_value. 142 // Simple switches that have no value should use "" for command_line_value.
143 const char* command_line_value; 143 const char* command_line_value;
144 144
145 // For ENABLE_DISABLE_VALUE, the command line switch and value to explicitly 145 // For ENABLE_DISABLE_VALUE, the command line switch and value to explicitly
146 // disable the feature. 146 // disable the feature.
147 const char* disable_command_line_switch; 147 const char* disable_command_line_switch;
148 const char* disable_command_line_value; 148 const char* disable_command_line_value;
149 149
150 // For FEATURE_VALUE, the base::Feature this entry corresponds to. 150 // For FEATURE_VALUE or FEATURE_WITH_VARIATIONS_VALUE, the base::Feature this
151 // entry corresponds to. The same feature must not be used in multiple
152 // FeatureEntries.
151 const base::Feature* feature; 153 const base::Feature* feature;
152 154
153 // Number of options to choose from. This is used if type is MULTI_VALUE, 155 // Number of options to choose from. This is used if type is MULTI_VALUE,
154 // ENABLE_DISABLE_VALUE, FEATURE_VALUE, or FEATURE_WITH_VARIATIONS_VALUE. 156 // ENABLE_DISABLE_VALUE, FEATURE_VALUE, or FEATURE_WITH_VARIATIONS_VALUE.
155 int num_options; 157 int num_options;
156 158
157 // This describes the options if type is MULTI_VALUE. 159 // This describes the options if type is MULTI_VALUE.
158 const Choice* choices; 160 const Choice* choices;
159 161
160 // This describes the options if type is FEATURE_WITH_VARIATIONS_VALUE. 162 // This describes the options if type is FEATURE_WITH_VARIATIONS_VALUE.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 195
194 // Separator used for multi values. Multi values are represented in prefs as 196 // Separator used for multi values. Multi values are represented in prefs as
195 // name-of-experiment + kMultiSeparator + selected_index. 197 // name-of-experiment + kMultiSeparator + selected_index.
196 extern const char kMultiSeparator[]; 198 extern const char kMultiSeparator[];
197 199
198 } // namespace 200 } // namespace
199 201
200 } // namespace flag_ui 202 } // namespace flag_ui
201 203
202 #endif // COMPONENTS_FLAGS_UI_FEATURE_ENTRY_H_ 204 #endif // COMPONENTS_FLAGS_UI_FEATURE_ENTRY_H_
OLDNEW
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/flags_ui/feature_entry_macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698