Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2706713002: Introduce BackwardCodePointStateMachine to traverse chars in code points (Closed)

Created:
3 years, 10 months ago by yabinh
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
aelias_OOO_until_Jul13, blink-reviews, Changwan Ryu, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce BackwardCodePointStateMachine to traverse chars in code points This is a pre-CL of https://codereview.chromium.org/2617443002/ BUG=595525 TEST=run_webkit_unit_tests --gtest_filter=BackwardCodePointStateMachineTest.* Review-Url: https://codereview.chromium.org/2706713002 Cr-Commit-Position: refs/heads/master@{#451566} Committed: https://chromium.googlesource.com/chromium/src/+/b21d309ca9519eaa367e39a2ee8e447e955718ac

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/state_machines/BackwardCodePointStateMachine.h View 1 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/state_machines/BackwardCodePointStateMachine.cpp View 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/state_machines/BackwardCodePointStateMachineTest.cpp View 1 chunk +73 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (11 generated)
yabinh
PTAL, thanks! FYI, this CL is very similar to another CL tps://codereview.chromium.org/2708523002.
3 years, 10 months ago (2017-02-20 02:39:50 UTC) #7
yosin_UTC9
lgtm
3 years, 10 months ago (2017-02-20 05:46:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706713002/20001
3 years, 10 months ago (2017-02-20 05:46:49 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 05:53:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b21d309ca9519eaa367e39a2ee8e...

Powered by Google App Engine
This is Rietveld 408576698