Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 2708523002: Introduce ForwardCodePointStateMachine to traverse chars in code points (Closed)

Created:
3 years, 10 months ago by yabinh
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
aelias_OOO_until_Jul13, blink-reviews, Changwan Ryu, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce ForwardCodePointStateMachine to traverse chars in code points This is a pre-CL of https://codereview.chromium.org/2617443002/ BUG=595525 TEST=run_webkit_unit_tests --gtest_filter=ForwardCodePointStateMachineTest.* Review-Url: https://codereview.chromium.org/2708523002 Cr-Commit-Position: refs/heads/master@{#451572} Committed: https://chromium.googlesource.com/chromium/src/+/c88786898b6f37bf802e1db5aee843f3b27c1627

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/state_machines/ForwardCodePointStateMachine.h View 1 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/state_machines/ForwardCodePointStateMachine.cpp View 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/state_machines/ForwardCodePointStateMachineTest.cpp View 1 chunk +73 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
yosin_UTC9
lgtm
3 years, 10 months ago (2017-02-20 05:47:03 UTC) #10
commit-bot: I haz the power
This CL has an open dependency (Issue 2706713002 Patch 20001). Please resolve the dependency and ...
3 years, 10 months ago (2017-02-20 05:47:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708523002/20001
3 years, 10 months ago (2017-02-20 06:06:11 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 06:10:41 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c88786898b6f37bf802e1db5aee8...

Powered by Google App Engine
This is Rietveld 408576698