Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: third_party/WebKit/Source/core/inspector/IdentifiersFactory.h

Issue 2706643002: DevTools: Move network request instrumentation points for timeline down the stack. (Closed)
Patch Set: addressing comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/IdentifiersFactory.h
diff --git a/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h b/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h
index d0b1efcc508a50af90bc0bf7165a4d86bf66eebb..cf34e7c676d1bb91de93acbe872a589fbd1b1ee8 100644
--- a/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h
+++ b/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h
@@ -27,6 +27,7 @@
#define IdentifiersFactory_h
#include "core/CoreExport.h"
+#include "platform/instrumentation/inspector/PlatformIdentifiersFactory.h"
#include "wtf/Allocator.h"
#include "wtf/text/WTFString.h"
@@ -36,23 +37,15 @@ class DocumentLoader;
class LocalFrame;
class InspectedFrames;
-class CORE_EXPORT IdentifiersFactory {
+class CORE_EXPORT IdentifiersFactory : public PlatformIdentifiersFactory {
caseq 2017/02/21 22:53:30 Why?
alph 2017/02/22 00:31:31 That was ok, but it's gone anyway.
STATIC_ONLY(IdentifiersFactory);
public:
- static String createIdentifier();
-
- static String requestId(unsigned long identifier);
-
static String frameId(LocalFrame*);
static LocalFrame* frameById(InspectedFrames*, const String&);
static String loaderId(DocumentLoader*);
static DocumentLoader* loaderById(InspectedFrames*, const String&);
-
- private:
- static String addProcessIdPrefixTo(int id);
- static int removeProcessIdPrefixFrom(const String&, bool* ok);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698