Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Side by Side Diff: third_party/WebKit/Source/core/inspector/IdentifiersFactory.h

Issue 2706643002: DevTools: Move network request instrumentation points for timeline down the stack. (Closed)
Patch Set: addressing comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef IdentifiersFactory_h 26 #ifndef IdentifiersFactory_h
27 #define IdentifiersFactory_h 27 #define IdentifiersFactory_h
28 28
29 #include "core/CoreExport.h" 29 #include "core/CoreExport.h"
30 #include "platform/instrumentation/inspector/PlatformIdentifiersFactory.h"
30 #include "wtf/Allocator.h" 31 #include "wtf/Allocator.h"
31 #include "wtf/text/WTFString.h" 32 #include "wtf/text/WTFString.h"
32 33
33 namespace blink { 34 namespace blink {
34 35
35 class DocumentLoader; 36 class DocumentLoader;
36 class LocalFrame; 37 class LocalFrame;
37 class InspectedFrames; 38 class InspectedFrames;
38 39
39 class CORE_EXPORT IdentifiersFactory { 40 class CORE_EXPORT IdentifiersFactory : public PlatformIdentifiersFactory {
caseq 2017/02/21 22:53:30 Why?
alph 2017/02/22 00:31:31 That was ok, but it's gone anyway.
40 STATIC_ONLY(IdentifiersFactory); 41 STATIC_ONLY(IdentifiersFactory);
41 42
42 public: 43 public:
43 static String createIdentifier();
44
45 static String requestId(unsigned long identifier);
46
47 static String frameId(LocalFrame*); 44 static String frameId(LocalFrame*);
48 static LocalFrame* frameById(InspectedFrames*, const String&); 45 static LocalFrame* frameById(InspectedFrames*, const String&);
49 46
50 static String loaderId(DocumentLoader*); 47 static String loaderId(DocumentLoader*);
51 static DocumentLoader* loaderById(InspectedFrames*, const String&); 48 static DocumentLoader* loaderById(InspectedFrames*, const String&);
52
53 private:
54 static String addProcessIdPrefixTo(int id);
55 static int removeProcessIdPrefixFrom(const String&, bool* ok);
56 }; 49 };
57 50
58 } // namespace blink 51 } // namespace blink
59 52
60 #endif // IdentifiersFactory_h 53 #endif // IdentifiersFactory_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698