Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

Issue 2706643002: DevTools: Move network request instrumentation points for timeline down the stack. (Closed)
Patch Set: addressing comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
index 450a12edc16578e963ff9b3dc5a9f9764c1c3f6d..f5ef7c0905094f75cbe0f775aec7cb72712608bc 100644
--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
@@ -31,6 +31,7 @@
#include "core/loader/DocumentThreadableLoader.h"
+#include <memory>
#include "core/dom/Document.h"
#include "core/dom/TaskRunnerHelper.h"
#include "core/frame/FrameConsole.h"
@@ -45,6 +46,7 @@
#include "core/page/ChromeClient.h"
#include "core/page/Page.h"
#include "platform/SharedBuffer.h"
+#include "platform/instrumentation/inspector/PlatformInspectorTraceEvents.h"
#include "platform/loader/fetch/CrossOriginAccessControl.h"
#include "platform/loader/fetch/FetchRequest.h"
#include "platform/loader/fetch/FetchUtils.h"
@@ -59,7 +61,6 @@
#include "wtf/Assertions.h"
#include "wtf/PtrUtil.h"
#include "wtf/WeakPtr.h"
-#include <memory>
namespace blink {
@@ -772,9 +773,8 @@ void DocumentThreadableLoader::reportResponseReceived(
DCHECK(frame);
if (!frame)
return;
- TRACE_EVENT1(
- "devtools.timeline", "ResourceReceiveResponse", "data",
- InspectorReceiveResponseEvent::data(identifier, frame, response));
+ TRACE_EVENT1("devtools.timeline", "ResourceReceiveResponse", "data",
caseq 2017/02/21 22:53:30 We really need them properly attributed on the fro
alph 2017/02/22 00:31:31 It is possible to reconstruct the frame from sendR
+ InspectorReceiveResponseEvent::data(identifier, response));
DocumentLoader* loader = frame->loader().documentLoader();
InspectorInstrumentation::didReceiveResourceResponse(
frame, identifier, loader, response, resource());

Powered by Google App Engine
This is Rietveld 408576698