Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2706623004: Added CSSPropertyDescriptor.h.tmpl to generate CSSPropertyDescriptor.h. (Closed)

Created:
3 years, 10 months ago by shend
Modified:
3 years, 10 months ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added CSSPropertyDescriptor.h.tmpl to generate CSSPropertyDescriptor.h. Added CSSPropertyDescriptor.h.tmpl and modified make_css_property_apis.py to generate CSSPropertyDescriptor.h. As a result of this, new methods added to the API no longer need to be added to the struct in CSSPropertyDescriptor.h - the function pointers in this file correspond to the methods defined in CSSPropertyAPIMethods.json5. Gist of the generated code: https://gist.github.com/anonymous/b315505ebc11cbd8901afd3bb01a620a Diff of original code vs generated: https://www.diffchecker.com/qPe6SX85 Original patch: https://codereview.chromium.org/2684353002 BUG=668012 Review-Url: https://codereview.chromium.org/2706623004 Cr-Commit-Position: refs/heads/master@{#451702} Committed: https://chromium.googlesource.com/chromium/src/+/af5f2e5981768c38c4d6856d8605bddfdc7bd977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -29 lines) Patch
M third_party/WebKit/Source/build/scripts/make_css_property_apis.py View 2 chunks +8 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.h.tmpl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
shend
Hi Sasha, landing this for Anna. Original patch was already lgtm'd.
3 years, 10 months ago (2017-02-20 05:47:49 UTC) #3
sashab
Thanks for those links in the CL description!! That is great to see -- would ...
3 years, 10 months ago (2017-02-20 23:25:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706623004/1
3 years, 10 months ago (2017-02-21 04:40:19 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 04:47:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/af5f2e5981768c38c4d6856d8605...

Powered by Google App Engine
This is Rietveld 408576698