third_party/WebKit/public/platform/WebImageGenerator.h - Issue 2706453003: switch to new ImageGenerator API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebImageGenerator.h

Issue 2706453003: switch to new ImageGenerator API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/platform/WebImageGenerator.h

diff --git a/third_party/WebKit/public/platform/WebImageGenerator.h b/third_party/WebKit/public/platform/WebImageGenerator.h

index 73cb2e8a899f8e2b89b4a3ef378d1b19afc627a0..53d9e055da6ac9413d8d0963df1650c71b18cf38 100644

--- a/third_party/WebKit/public/platform/WebImageGenerator.h

+++ b/third_party/WebKit/public/platform/WebImageGenerator.h

@@ -31,6 +31,7 @@

#ifndef WebImageGenerator_h

#define WebImageGenerator_h

+#include "SkRefCnt.h"

#include "WebCommon.h"

class SkData;

@@ -40,7 +41,7 @@ namespace blink {

class BLINK_PLATFORM_EXPORT WebImageGenerator {

public:

- static SkImageGenerator* create(SkData*);

+ static std::unique_ptr<SkImageGenerator> create(sk_sp<SkData>);

chrishtr 2017/02/17 17:14:51 It's not clear to me immediately from digging into

reed1 2017/02/17 18:13:28 Yes, that is why we changed the factory's signatur

};

} // namespace blink