third_party/WebKit/public/platform/WebImageGenerator.h - Issue 2706453003: switch to new ImageGenerator API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/WebImageGenerator.h

Issue 2706453003: switch to new ImageGenerator API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp ('K') | « third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2015 Google Inc. All rights reserved.	2 * Copyright (C) 2015 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 13 matching lines...) Expand all Loading...
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,	24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,

25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY	25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY

26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT	26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE	27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

29 */	29 */

30	30

31 #ifndef WebImageGenerator_h	31 #ifndef WebImageGenerator_h

32 #define WebImageGenerator_h	32 #define WebImageGenerator_h

33	33

	34 #include "SkRefCnt.h"

34 #include "WebCommon.h"	35 #include "WebCommon.h"

35	36

36 class SkData;	37 class SkData;

37 class SkImageGenerator;	38 class SkImageGenerator;

38	39

39 namespace blink {	40 namespace blink {

40	41

41 class BLINK_PLATFORM_EXPORT WebImageGenerator {	42 class BLINK_PLATFORM_EXPORT WebImageGenerator {

42 public:	43 public:

43 static SkImageGenerator* create(SkData*);	44 static std::unique_ptr<SkImageGenerator> create(sk_sp<SkData>);
	chrishtr 2017/02/17 17:14:51 It's not clear to me immediately from digging into It's not clear to me immediately from digging into the Skia code what happens with the pointer that is returned from this. Does it cleanly obey unique_ptr semantics? reed1 2017/02/17 18:13:28 Yes, that is why we changed the factory's signatur Show quoted text On 2017/02/17 17:14:51, chrishtr wrote: > It's not clear to me immediately from digging into the Skia code what happens > with the pointer that > is returned from this. Does it cleanly obey unique_ptr semantics? Yes, that is why we changed the factory's signature. create() returns a ptr that is uniquely owned by the caller.
44 };	45 };

45	46

46 } // namespace blink	47 } // namespace blink

47	48

48 #endif	49 #endif

OLD	NEW