Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 2706453003: switch to new ImageGenerator API

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 days, 9 hours ago by reed1
Modified:
2 days, 1 hour ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, dshwang_vacation_until_17th, drott+blinkwatch_chromium.org, krit, feature-media-reviews_chromium.org, fmalita+watch_chromium.org, jam (OOO), jbroman, Justin Novosad, kinuko+watch, mlamouri+watch-content_chromium.org, pdr+graphicswatchlist_chromium.org, posciak+watch_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

switch to new ImageGenerator API Since the image is the exclusive owner of the generator, change the parameter type to std::unique_ptr<SkImageGenerator> BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix skia_common #

Patch Set 3 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M cc/test/skia_common.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebImageGenerator.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/WebImageGenerator.h View 2 chunks +2 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 30 (20 generated)
reed1
2 days, 9 hours ago (2017-02-17 16:27:05 UTC) #5
reed1
need owners for WebKit/public, content, media for refactoring CL
2 days, 9 hours ago (2017-02-17 16:30:36 UTC) #7
f(malita)
lgtm https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp File third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp (right): https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp#newcode331 third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp:331: std::unique_ptr<DecodingImageGenerator> generator(new DecodingImageGenerator( nit: WTF::makeUnique(...);
2 days, 8 hours ago (2017-02-17 16:41:08 UTC) #8
chrishtr
https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/public/platform/WebImageGenerator.h File third_party/WebKit/public/platform/WebImageGenerator.h (right): https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/public/platform/WebImageGenerator.h#newcode44 third_party/WebKit/public/platform/WebImageGenerator.h:44: static std::unique_ptr<SkImageGenerator> create(sk_sp<SkData>); It's not clear to me immediately ...
2 days, 8 hours ago (2017-02-17 17:14:52 UTC) #11
reed1
https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/public/platform/WebImageGenerator.h File third_party/WebKit/public/platform/WebImageGenerator.h (right): https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/public/platform/WebImageGenerator.h#newcode44 third_party/WebKit/public/platform/WebImageGenerator.h:44: static std::unique_ptr<SkImageGenerator> create(sk_sp<SkData>); On 2017/02/17 17:14:51, chrishtr wrote: > ...
2 days, 7 hours ago (2017-02-17 18:13:29 UTC) #13
reed1
https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp File third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp (right): https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp#newcode331 third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp:331: std::unique_ptr<DecodingImageGenerator> generator(new DecodingImageGenerator( On 2017/02/17 16:41:08, f(malita) wrote: > ...
2 days, 7 hours ago (2017-02-17 18:19:35 UTC) #16
reed1
2 days, 6 hours ago (2017-02-17 19:19:11 UTC) #19
chrishtr
lgtm
2 days, 6 hours ago (2017-02-17 19:28:33 UTC) #22
reed1
owners ptal
2 days, 2 hours ago (2017-02-17 23:39:17 UTC) #29
chrishtr
2 days, 1 hour ago (2017-02-17 23:55:42 UTC) #30
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd