switch to new ImageGenerator API

switch to new ImageGenerator API

Since the image is the exclusive owner of the generator, change the parameter type to std::unique_ptr<SkImageGenerator>

BUG=skia:5077
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=hubbe

Review-Url: https://codereview.chromium.org/2706453003
Cr-Commit-Position: refs/heads/master@{#451848}
Committed: https://chromium.googlesource.com/chromium/src/+/08cd16372dba031d8adac493288fbe1a8c67a678

[reed1, 2017-02-17 16:26:20]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 16:26:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2017-02-17 16:26:52]

Description was changed from

==========
switch to new ImageGenerator API

BUG=
==========

to

==========
switch to new ImageGenerator API

Since the image is the exclusive owner of the generator, change the parameter
type to std::unique_ptr<SkImageGenerator>

BUG=
==========

[reed1, 2017-02-17 16:27:04]

reed@google.com changed reviewers:
+ fmalita@chromium.org

[reed1, 2017-02-17 16:30:36]

reed@google.com changed reviewers:
+ chrishtr@chromium.org, hubbe@chromium.org, jochen@chromium.org

[reed1, 2017-02-17 16:30:36]

need owners for WebKit/public, content, media for refactoring CL

[f(malita), 2017-02-17 16:41:08]

lgtm

https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
(right):

https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp:331:
std::unique_ptr<DecodingImageGenerator> generator(new DecodingImageGenerator(
nit: WTF::makeUnique(...);

[commit-bot: I haz the power, 2017-02-17 16:45:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 16:45:20]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-02-17 17:14:52]

https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebImageGenerator.h (right):

https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebImageGenerator.h:44: static
std::unique_ptr<SkImageGenerator> create(sk_sp<SkData>);
It's not clear to me immediately from digging into the Skia code what happens
with the pointer that
is returned from this. Does it cleanly obey unique_ptr semantics?

[reed1, 2017-02-17 18:13:13]

Description was changed from

==========
switch to new ImageGenerator API

Since the image is the exclusive owner of the generator, change the parameter
type to std::unique_ptr<SkImageGenerator>

BUG=
==========

to

==========
switch to new ImageGenerator API

Since the image is the exclusive owner of the generator, change the parameter
type to std::unique_ptr<SkImageGenerator>

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[reed1, 2017-02-17 18:13:29]

https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebImageGenerator.h (right):

https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebImageGenerator.h:44: static
std::unique_ptr<SkImageGenerator> create(sk_sp<SkData>);
On 2017/02/17 17:14:51, chrishtr wrote:
> It's not clear to me immediately from digging into the Skia code what happens
> with the pointer that
> is returned from this. Does it cleanly obey unique_ptr semantics?

Yes, that is why we changed the factory's signature. create() returns a ptr that
is uniquely owned by the caller.

[reed1, 2017-02-17 18:14:07]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 18:15:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2017-02-17 18:19:35]

https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
(right):

https://codereview.chromium.org/2706453003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp:331:
std::unique_ptr<DecodingImageGenerator> generator(new DecodingImageGenerator(
On 2017/02/17 16:41:08, f(malita) wrote:
> nit: WTF::makeUnique(...);

Done.

[commit-bot: I haz the power, 2017-02-17 18:51:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 18:51:25]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[reed1, 2017-02-17 19:19:17]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 19:19:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-02-17 19:28:33]

lgtm

[commit-bot: I haz the power, 2017-02-17 20:41:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:41:24]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[reed1, 2017-02-17 21:33:58]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 21:34:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 23:37:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:37:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[reed1, 2017-02-17 23:39:17]

owners ptal

[chrishtr, 2017-02-17 23:55:42]

lgtm

[jochen (gone - plz use gerrit), 2017-02-20 09:29:58]

lgtm

[jochen (gone - plz use gerrit), 2017-02-20 09:30:09]

please reference a tracking bug from the CL description

[reed1, 2017-02-20 14:51:39]

Description was changed from

==========
switch to new ImageGenerator API

Since the image is the exclusive owner of the generator, change the parameter
type to std::unique_ptr<SkImageGenerator>

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
switch to new ImageGenerator API

Since the image is the exclusive owner of the generator, change the parameter
type to std::unique_ptr<SkImageGenerator>

BUG=skia:5077
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[reed1, 2017-02-20 14:51:53]

On 2017/02/20 09:30:09, jochen wrote:
> please reference a tracking bug from the CL description

done

[reed1, 2017-02-20 14:51:59]

The CQ bit was checked by reed@google.com

[reed1, 2017-02-20 14:51:59]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/2706453003/#ps40001
(title: "fix typo")

[commit-bot: I haz the power, 2017-02-20 14:52:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 15:00:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 15:00:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[reed1, 2017-02-20 15:13:08]

reed@google.com changed reviewers:
+ danakj@chromium.org, enne@chromium.org, vmpstr@chromium.org

[reed1, 2017-02-20 15:13:09]

need OWNER for cc/test

[reed1, 2017-02-20 16:38:55]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 16:39:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 18:45:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 18:45:54]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-02-21 17:08:45]

lgtm

[reed1, 2017-02-21 17:43:59]

The CQ bit was checked by reed@google.com

[reed1, 2017-02-21 17:43:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, jochen@chromium.org, fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/2706453003/#ps50001
(title: "fix new site in tile_manager_unittest.cc")

[commit-bot: I haz the power, 2017-02-21 17:44:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 19:04:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 19:04:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[reed1, 2017-02-21 20:43:41]

Description was changed from

==========
switch to new ImageGenerator API

Since the image is the exclusive owner of the generator, change the parameter
type to std::unique_ptr<SkImageGenerator>

BUG=skia:5077
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
switch to new ImageGenerator API

Since the image is the exclusive owner of the generator, change the parameter
type to std::unique_ptr<SkImageGenerator>

BUG=skia:5077
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=hubbe
==========

[reed1, 2017-02-21 20:43:52]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2017-02-21 20:45:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 22:11:46]

CQ is committing da patch.

Bot data: {"patchset_id": 50001, "attempt_start_ts": 1487709832130670,
"parent_rev": "dd47ba396451348cc15ecbc53255cb618e457414", "commit_rev":
"08cd16372dba031d8adac493288fbe1a8c67a678"}

[commit-bot: I haz the power, 2017-02-21 22:12:23]

Description was changed from

==========
switch to new ImageGenerator API

Since the image is the exclusive owner of the generator, change the parameter
type to std::unique_ptr<SkImageGenerator>

BUG=skia:5077
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=hubbe
==========

to

==========
switch to new ImageGenerator API

Since the image is the exclusive owner of the generator, change the parameter
type to std::unique_ptr<SkImageGenerator>

BUG=skia:5077
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=hubbe

Review-Url: https://codereview.chromium.org/2706453003
Cr-Commit-Position: refs/heads/master@{#451848}
Committed:
https://chromium.googlesource.com/chromium/src/+/08cd16372dba031d8adac493288f...
==========

[commit-bot: I haz the power, 2017-02-21 22:12:26]

Committed patchset #4 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/08cd16372dba031d8adac493288f...