Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2706303004: Revert of [wasm] Remove support for experimental version 0xD. (Closed)

Created:
3 years, 10 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
Reviewers:
titzer, Mircea Trofin, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Remove support for experimental version 0xD. (patchset #3 id:40001 of https://codereview.chromium.org/2709753003/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/13730 Original issue's description: > [wasm] Remove support for experimental version 0xD. > > R=mtrofin@chromium.org > BUG=chromium:575167, chromium:694657 > > Review-Url: https://codereview.chromium.org/2709753003 > Cr-Commit-Position: refs/heads/master@{#43368} > Committed: https://chromium.googlesource.com/v8/v8/+/c8329253ea345e06a923f7800f96f4ef59262997 TBR=ahaas@chromium.org,mtrofin@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167, chromium:694657 Review-Url: https://codereview.chromium.org/2706303004 Cr-Commit-Position: refs/heads/master@{#43373} Committed: https://chromium.googlesource.com/v8/v8/+/5004748868a15be9ba47727ab15c278fcca4f2b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M src/wasm/module-decoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/wasm/jsapi-harness.js View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [wasm] Remove support for experimental version 0xD.
3 years, 10 months ago (2017-02-22 13:59:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706303004/1
3 years, 10 months ago (2017-02-22 13:59:11 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 13:59:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5004748868a15be9ba47727ab15c278fcca...

Powered by Google App Engine
This is Rietveld 408576698