Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2709753003:
[wasm] Remove support for experimental version 0xD. (Closed)
Description[wasm] Remove support for experimental version 0xD.
R=mtrofin@chromium.org
BUG=chromium:575167, chromium:694657
Review-Url: https://codereview.chromium.org/2709753003
Cr-Original-Commit-Position: refs/heads/master@{#43368}
Committed: https://chromium.googlesource.com/v8/v8/+/c8329253ea345e06a923f7800f96f4ef59262997
Review-Url: https://codereview.chromium.org/2709753003
Cr-Commit-Position: refs/heads/master@{#43383}
Committed: https://chromium.googlesource.com/v8/v8/+/6a09a41622d65d07fcb4436ddfaaaa6a9cad2467
Patch Set 1 #Patch Set 2 : [wasm] Remove support for experimental version 0xD. #Patch Set 3 : Fix jsapi-harness.js #
Messages
Total messages: 29 (21 generated)
The CQ bit was checked by titzer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [wasm] Remove support for experimental version 0xD. R=mtrofin@chromium.org BUG=chromium:575167 ========== to ========== [wasm] Remove support for experimental version 0xD. R=mtrofin@chromium.org BUG=chromium:575167,chromium:694657 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
The CQ bit was checked by titzer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
The CQ bit was checked by titzer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
titzer@chromium.org changed reviewers: + ahaas@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by titzer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487765068760880,
"parent_rev": "c7add4ce57d6424569a146aef9d04682cb40fc1c", "commit_rev":
"c8329253ea345e06a923f7800f96f4ef59262997"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] Remove support for experimental version 0xD. R=mtrofin@chromium.org BUG=chromium:575167,chromium:694657 ========== to ========== [wasm] Remove support for experimental version 0xD. R=mtrofin@chromium.org BUG=chromium:575167,chromium:694657 Review-Url: https://codereview.chromium.org/2709753003 Cr-Commit-Position: refs/heads/master@{#43368} Committed: https://chromium.googlesource.com/v8/v8/+/c8329253ea345e06a923f7800f96f4ef592... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/c8329253ea345e06a923f7800f96f4ef592...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2706303004/ by machenbach@chromium.org. The reason for reverting is: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....
Message was sent while issue was closed.
Description was changed from ========== [wasm] Remove support for experimental version 0xD. R=mtrofin@chromium.org BUG=chromium:575167,chromium:694657 Review-Url: https://codereview.chromium.org/2709753003 Cr-Commit-Position: refs/heads/master@{#43368} Committed: https://chromium.googlesource.com/v8/v8/+/c8329253ea345e06a923f7800f96f4ef592... ========== to ========== [wasm] Remove support for experimental version 0xD. R=mtrofin@chromium.org BUG=chromium:575167,chromium:694657 Review-Url: https://codereview.chromium.org/2709753003 Cr-Commit-Position: refs/heads/master@{#43368} Committed: https://chromium.googlesource.com/v8/v8/+/c8329253ea345e06a923f7800f96f4ef592... ==========
The CQ bit was checked by mtrofin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487797243804780,
"parent_rev": "f8158cdbdb58dfbf095581af386ceac7f7314af7", "commit_rev":
"6a09a41622d65d07fcb4436ddfaaaa6a9cad2467"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] Remove support for experimental version 0xD. R=mtrofin@chromium.org BUG=chromium:575167,chromium:694657 Review-Url: https://codereview.chromium.org/2709753003 Cr-Commit-Position: refs/heads/master@{#43368} Committed: https://chromium.googlesource.com/v8/v8/+/c8329253ea345e06a923f7800f96f4ef592... ========== to ========== [wasm] Remove support for experimental version 0xD. R=mtrofin@chromium.org BUG=chromium:575167,chromium:694657 Review-Url: https://codereview.chromium.org/2709753003 Cr-Original-Commit-Position: refs/heads/master@{#43368} Committed: https://chromium.googlesource.com/v8/v8/+/c8329253ea345e06a923f7800f96f4ef592... Review-Url: https://codereview.chromium.org/2709753003 Cr-Commit-Position: refs/heads/master@{#43383} Committed: https://chromium.googlesource.com/v8/v8/+/6a09a41622d65d07fcb4436ddfaaaa6a9ca... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/6a09a41622d65d07fcb4436ddfaaaa6a9ca... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
