Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2706293013: Add tests for exiting from nested fullscreen (Closed)

Created:
3 years, 10 months ago by foolip
Modified:
3 years, 10 months ago
Reviewers:
esprehn, Mike West, eae
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for exiting from nested fullscreen Tests for https://github.com/whatwg/fullscreen/pull/72. Before that change, the per-spec pass condition for the nested-in-iframe case would have been to exit fully to the outer document, which was a spec bug and doesn't match implementations. In order to automate these tests, it was necessary to teach auto-click.js to traverse out of iframes to take their position into account. These tests have also been run manually in Firefox Nightly and confirmed to pass there. Actually adopting the new spec wording will be part of relanding issue 402376, together with other necessary spec changes. BUG=402376 Review-Url: https://codereview.chromium.org/2706293013 Cr-Commit-Position: refs/heads/master@{#452841} Committed: https://chromium.googlesource.com/chromium/src/+/4e61b6d5137e87d2178daa2b07f55a4c62c3cd4d

Patch Set 1 #

Total comments: 6

Patch Set 2 : tweak auto-click.js style #

Messages

Total messages: 15 (10 generated)
foolip
Some simple tests, PTAL, but please don't CQ unless the spec PR has already been ...
3 years, 10 months ago (2017-02-24 11:04:12 UTC) #6
Mike West
LGTM % some suggestions for the test. https://codereview.chromium.org/2706293013/diff/1/third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js File third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js (right): https://codereview.chromium.org/2706293013/diff/1/third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js#newcode8 third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js:8: return { ...
3 years, 10 months ago (2017-02-24 11:37:16 UTC) #8
foolip
Thanks Mike! https://codereview.chromium.org/2706293013/diff/1/third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js File third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js (right): https://codereview.chromium.org/2706293013/diff/1/third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js#newcode8 third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js:8: return { left: rect.left, top: rect.top }; ...
3 years, 10 months ago (2017-02-24 15:12:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706293013/20001
3 years, 10 months ago (2017-02-24 15:13:17 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 16:23:22 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4e61b6d5137e87d2178daa2b07f5...

Powered by Google App Engine
This is Rietveld 408576698