Add tests for exiting from nested fullscreen

Add tests for exiting from nested fullscreen

Tests for https://github.com/whatwg/fullscreen/pull/72.

Before that change, the per-spec pass condition for the nested-in-iframe
case would have been to exit fully to the outer document, which was a
spec bug and doesn't match implementations.

In order to automate these tests, it was necessary to teach
auto-click.js to traverse out of iframes to take their position into
account.

These tests have also been run manually in Firefox Nightly and confirmed
to pass there.

Actually adopting the new spec wording will be part of relanding issue
402376, together with other necessary spec changes.

BUG=402376
Review-Url: https://codereview.chromium.org/2706293013
Cr-Commit-Position: refs/heads/master@{#452841}
Committed: https://chromium.googlesource.com/chromium/src/+/4e61b6d5137e87d2178daa2b07f55a4c62c3cd4d

[foolip, 2017-02-24 10:21:00]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 10:21:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 10:38:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 10:38:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[foolip, 2017-02-24 11:04:11]

foolip@chromium.org changed reviewers:
+ eae@chromium.org, esprehn@chromium.org

[foolip, 2017-02-24 11:04:12]

Some simple tests, PTAL, but please don't CQ unless the spec PR has already been
merged (unlikely).

[Mike West, 2017-02-24 11:37:15]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2017-02-24 11:37:16]

LGTM % some suggestions for the test.

https://codereview.chromium.org/2706293013/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js
(right):

https://codereview.chromium.org/2706293013/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js:8:
return { left: rect.left, top: rect.top };
I must be getting old, but the `{}` for the object confused me given the lack of
`{}` for the `if`. Would you mind terribly putting braces around the body here?

https://codereview.chromium.org/2706293013/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js:9:
const style = getComputedStyle(iframe);
I don't think you actually use this. Is it just to force a recalc?

https://codereview.chromium.org/2706293013/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js:10:
function get(prop) {
Hrm. I don't know if we have a style-guide about nested functions, but I'd
personally change this to something like:

```
var get = prop => +/[\d.]*/.exec(style[prop])[0];
```

[foolip, 2017-02-24 15:12:59]

Thanks Mike!

https://codereview.chromium.org/2706293013/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js
(right):

https://codereview.chromium.org/2706293013/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js:8:
return { left: rect.left, top: rect.top };
On 2017/02/24 11:37:16, Mike West (sloooooow) wrote:
> I must be getting old, but the `{}` for the object confused me given the lack
of
> `{}` for the `if`. Would you mind terribly putting braces around the body
here?

Ah, this does look a bit, more {} it is.

https://codereview.chromium.org/2706293013/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js:9:
const style = getComputedStyle(iframe);
On 2017/02/24 11:37:16, Mike West (sloooooow) wrote:
> I don't think you actually use this. Is it just to force a recalc?

It's used as style[prop] inside the get function.

https://codereview.chromium.org/2706293013/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js:10:
function get(prop) {
On 2017/02/24 11:37:16, Mike West (sloooooow) wrote:
> Hrm. I don't know if we have a style-guide about nested functions, but I'd
> personally change this to something like:
> 
> ```
> var get = prop => +/[\d.]*/.exec(style[prop])[0];
> ```

Didn't think of that, done. (I also threw in some var->const)

[foolip, 2017-02-24 15:13:04]

The CQ bit was checked by foolip@chromium.org

[foolip, 2017-02-24 15:13:05]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2706293013/#ps20001
(title: "tweak auto-click.js style")

[commit-bot: I haz the power, 2017-02-24 15:13:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 16:22:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487949184729090,
"parent_rev": "747265bacb740e3f91170b6e271efcc72737c5b8", "commit_rev":
"4e61b6d5137e87d2178daa2b07f55a4c62c3cd4d"}

[commit-bot: I haz the power, 2017-02-24 16:23:21]

Description was changed from

==========
Add tests for exiting from nested fullscreen

Tests for https://github.com/whatwg/fullscreen/pull/72.

Before that change, the per-spec pass condition for the nested-in-iframe
case would have been to exit fully to the outer document, which was a
spec bug and doesn't match implementations.

In order to automate these tests, it was necessary to teach
auto-click.js to traverse out of iframes to take their position into
account.

These tests have also been run manually in Firefox Nightly and confirmed
to pass there.

Actually adopting the new spec wording will be part of relanding issue
402376, together with other necessary spec changes.

BUG=402376
==========

to

==========
Add tests for exiting from nested fullscreen

Tests for https://github.com/whatwg/fullscreen/pull/72.

Before that change, the per-spec pass condition for the nested-in-iframe
case would have been to exit fully to the outer document, which was a
spec bug and doesn't match implementations.

In order to automate these tests, it was necessary to teach
auto-click.js to traverse out of iframes to take their position into
account.

These tests have also been run manually in Firefox Nightly and confirmed
to pass there.

Actually adopting the new spec wording will be part of relanding issue
402376, together with other necessary spec changes.

BUG=402376

Review-Url: https://codereview.chromium.org/2706293013
Cr-Commit-Position: refs/heads/master@{#452841}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e61b6d5137e87d2178daa2b07f5...
==========

[commit-bot: I haz the power, 2017-02-24 16:23:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4e61b6d5137e87d2178daa2b07f5...