third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js - Issue 2706293007: [DevTools] Fix Dialog's close button to properly close dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2706293007: [DevTools] Fix Dialog's close button to properly close dialog. (Closed)

Patch Set: test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

index 0f9428ccee13f49df14104465171e64454c55cf4..37d0a06fbc967884c595a6e873a1f32d18855c7f 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

@@ -446,7 +446,7 @@ Network.NetworkLogViewColumns = class {

var dialog = new UI.Dialog();

manageCustomHeaders.show(dialog.contentElement);

dialog.setSizeBehavior(UI.GlassPane.SizeBehavior.MeasureContent);

- dialog.showDialog(this._networkLogView.element);

+ dialog.show(this._networkLogView.element);

}

/**